Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for runtime config to scaffold cmd #16

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

rajatjindal
Copy link
Collaborator

@rajatjindal rajatjindal commented Feb 16, 2024

This PR refactor scaffold command a bit to make unit testing easier. and then commits to add unit tests and support for runtime config.

fixes #15

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
Copy link
Collaborator

@bacongobbler bacongobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/cmd/scaffold.go Show resolved Hide resolved
@bacongobbler bacongobbler merged commit 3d68660 into spinkube:main Feb 20, 2024
1 check passed
@bacongobbler bacongobbler deleted the runtime-config branch February 20, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add runtime config support for spin k8s scaffold
2 participants