Slight update to README (as per installation testing) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tpmccallum tim.mccallum@fermyon.com
tpmccallum
requested review from
bacongobbler and
rajatjindal
as code owners
tpmccallum
commented
Feb 26, 2024
| @@ -43,7 +50,7 @@ make install | |||
| ## Prerequisites | |||
|
|
|||
| Ensure spin-operator is installed in your Kubernetes cluster. See the [spin-operator Quickstart | |||
| Guide](https://github.com/spinkube/spin-operator/blob/main/documentation/content/quickstart.md). | |||
| Guide](https://github.com/spinkube/documentation/blob/main/content/en/docs/spin-operator/quickstart/_index.md). | |||
There was a problem hiding this comment.
Point to the new single source of truth for documentation (spinkube/documentation repository)
There was a problem hiding this comment.
We can update this Quickstart URL and some other repeatable URLs e.g. Prerequisites to live URLs once the documentation is published and public facing.
tpmccallum
commented
Feb 26, 2024
| Fetch the plugin: | ||
|
|
||
| ```sh | ||
| git clone git@github.com:spinkube/spin-plugin-k8s.git |
There was a problem hiding this comment.
Listing the fetch as to mirror all of the steps required to perform the installation from source.
bacongobbler
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tpmccallum tim.mccallum@fermyon.com