Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sigs): Submit proposal for a documentation SIG #20

Merged
merged 6 commits into from
Aug 29, 2019
Merged

feat(sigs): Submit proposal for a documentation SIG #20

merged 6 commits into from
Aug 29, 2019

Conversation

317brian
Copy link
Contributor

The documentation for Spinnaker can benefit from a group that looks at the documentation set holistically.

sig-documentation/README.md Outdated Show resolved Hide resolved
sig-documentation/README.md Outdated Show resolved Hide resolved

## Roles & Responsibilities of the SIG Leads

### SIG Lead(s):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ezimanyi -- someone from your side?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorbin: Is this something you'd be interested in being a part of?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and in fact I was just in communication with Brian and with Ben Klein about this. I'm glad Brian's taking the lead on this, and I definitely want to be a part of it.

@robzienert robzienert added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Aug 16, 2019
Co-Authored-By: Rob Zienert <rob@robzienert.com>
@aglover
Copy link
Contributor

aglover commented Aug 21, 2019

Sounds like @dorbin needs to be added as a SIG lead. Once that's done, I will notify the SC for a vote.

Added @dorbin to SIG Leads. Added code-driven doc generation to Scope of Work and Goals.
@aglover
Copy link
Contributor

aglover commented Aug 23, 2019

LGTM. +1 binding vote.

@rmeshenberg
Copy link

+1

1 similar comment
@duftler
Copy link

duftler commented Aug 23, 2019

+1

sig-documentation/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dorbin dorbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, sorry I'm a week late to the game. Been OOO and almost off the grid.
A few comments below.
I'm really happy about this, Brian, and I can't wait to see it happen.

sig-documentation/README.md Outdated Show resolved Hide resolved
sig-documentation/README.md Outdated Show resolved Hide resolved
sig-documentation/README.md Outdated Show resolved Hide resolved
sig-documentation/README.md Outdated Show resolved Hide resolved
sig-documentation/README.md Outdated Show resolved Hide resolved
sig-documentation/README.md Outdated Show resolved Hide resolved
sig-documentation/README.md Show resolved Hide resolved
317brian and others added 3 commits August 26, 2019 08:45
Co-Authored-By: Dave Dorbin <ddorbin@google.com>
Co-Authored-By: Dave Dorbin <ddorbin@google.com>
Add line about Spinnaker doc platform. Be explicit that the SIG doesn't include governance related docs.
@pstout
Copy link
Contributor

pstout commented Aug 26, 2019

+1 for this SIG

@aglover
Copy link
Contributor

aglover commented Aug 28, 2019

@demobox what say you?

@demobox
Copy link
Contributor

demobox commented Aug 29, 2019

demobox what say you?

+1 - looks good to me too (binding vote)

@aglover aglover merged commit 2b1a221 into spinnaker:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committee/steering Denotes an issue or PR intended to be handled by the steering committee. ready-for-vote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants