Skip to content

Commit

Permalink
fix(core/managed): re-enable build events (#8786)
Browse files Browse the repository at this point in the history
  • Loading branch information
Erik Munson committed Dec 11, 2020
1 parent 728939d commit 06aca3a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
6 changes: 1 addition & 5 deletions app/scripts/modules/core/src/managed/ArtifactDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ import { isResourceKindSupported } from './resources/resourceRegistry';

import './ArtifactDetail.less';

const SUPPORTED_PRE_DEPLOYMENT_TYPES = [
// KLUDGE WARNING: disabling build events temporarily while we get the API in shape
// 'BUILD',
'BAKE',
];
const SUPPORTED_PRE_DEPLOYMENT_TYPES = ['BUILD', 'BAKE'];

function shouldDisplayResource(reference: string, resource: IManagedResourceSummary) {
return isResourceKindSupported(resource.kind) && reference === resource.artifact?.reference;
Expand Down
8 changes: 1 addition & 7 deletions app/scripts/modules/core/src/managed/ArtifactsList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,7 @@ function getArtifactStatuses({ environments, lifecycleSteps }: IManagedArtifactV

const preDeploymentSteps = lifecycleSteps?.filter(
({ scope, type, status }) =>
scope === 'PRE_DEPLOYMENT' &&
[
// KLUDGE WARNING: disabling build events temporarily while we get the API in shape
// 'BUILD',
'BAKE',
].includes(type) &&
['RUNNING', 'FAILED'].includes(status),
scope === 'PRE_DEPLOYMENT' && ['BUILD', 'BAKE'].includes(type) && ['RUNNING', 'FAILED'].includes(status),
);

if (preDeploymentSteps?.length > 0) {
Expand Down

0 comments on commit 06aca3a

Please sign in to comment.