fix(kubernetes): safer lookups for deploy stage validators (#6847)

spinnaker · Apr 12, 2019 · 37e24d7 · 37e24d7
1 parent 478e326
commit 37e24d7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...pts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/deployManifest.validator.ts b/...pts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/deployManifest.validator.ts
@@ -1,4 +1,4 @@
-import { isEmpty } from 'lodash';
+import { get, isEmpty } from 'lodash';
 
 import { IPipeline, IStage, IValidatorConfig, ICustomValidator } from '@spinnaker/core';
 
@@ -7,8 +7,9 @@ export const deployManifestValidators = (): IValidatorConfig[] => {
     {
       type: 'custom',
       validate: (_pipeline: IPipeline, stage: IStage) => {
-        const { enabled = false, options = {} } = stage.trafficManagement;
-        if (enabled && isEmpty(options.services)) {
+        const enabled = get(stage, 'trafficManagement.enabled', false);
+        const services = get(stage, 'trafficManagement.options.services', []);
+        if (enabled && isEmpty(services)) {
           return `Select at least one <strong>Service</strong> to enable Spinnaker-managed rollout strategy options.`;
         }
         return null;