Oneliners (#5055)

* style(core): higher contrast background on active page in page navigator * style(core): use different icon for application in search * fix(core): do not throw exception on missing versioned provider
spinnaker · Mar 23, 2018 · 3e1d5c3 · 3e1d5c3
1 parent 507fc5e
commit 3e1d5c3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/app/scripts/modules/core/src/application/applicationSearchResultType.tsx b/app/scripts/modules/core/src/application/applicationSearchResultType.tsx
@@ -27,7 +27,7 @@ class ApplicationSearchResultType extends SearchResultType<IApplicationSearchRes
   public id = 'applications';
   public order = 1;
   public displayName = 'Applications';
-  public iconClass = 'fa fa-window-maximize';
+  public iconClass = 'far fa-window-maximize';
 
   private cols: { [key: string]: ISearchColumn } = {
     APPLICATION: { key: 'application', label: 'Name' },

diff --git a/app/scripts/modules/core/src/presentation/navigation/pageNavigation.less b/app/scripts/modules/core/src/presentation/navigation/pageNavigation.less
@@ -13,7 +13,7 @@ page-navigator {
     li {
       display: block;
       &:hover, &.current {
-        background-color: var(--color-cirrus);
+        background-color: var(--color-accent-g2);
         a {
           color: var(--color-primary);
         }

diff --git a/app/scripts/modules/core/src/serverGroup/serverGroup.transformer.js b/app/scripts/modules/core/src/serverGroup/serverGroup.transformer.js
@@ -25,12 +25,12 @@ module.exports = angular.module('spinnaker.core.serverGroup.transformer', [
     }
 
     function normalizeServerGroupForProviderVersion(serverGroup, application, providerVersion) {
-      const transformer = providerServiceDelegate
-        .getDelegate(serverGroup.provider || serverGroup.type, 'serverGroup.transformer', providerVersion);
-      if (!transformer) {
+      if (!providerServiceDelegate.hasDelegate(serverGroup.provider || serverGroup.type, 'serverGroup.transformer', providerVersion)) {
         return null;
       }
-      return transformer.normalizeServerGroup(serverGroup, application);
+      return providerServiceDelegate
+        .getDelegate(serverGroup.provider || serverGroup.type, 'serverGroup.transformer', providerVersion)
+        .normalizeServerGroup(serverGroup, application);
     }
 
     function convertServerGroupCommandToDeployConfiguration(base) {