Skip to content

Commit

Permalink
chore(deck-kayenta): bump package to 0.0.43 (#5217)
Browse files Browse the repository at this point in the history
* refactor(*): de-angularize help contents/registry (#5199)

* chore(*): bump packages for de-angularized help contents (#5200)

* chore(core): bump package to 0.0.197 (#5202)

* fix(core): fix HelpField export (#5204)

* chore(deck-kayenta): bump package to 0.0.43 (#5216)
  • Loading branch information
Scott Bloch-Wehba-Seaward committed Apr 20, 2018
1 parent 01f4bda commit 4b39044
Show file tree
Hide file tree
Showing 53 changed files with 690 additions and 752 deletions.
2 changes: 1 addition & 1 deletion app/scripts/modules/amazon/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@spinnaker/amazon",
"version": "0.0.90",
"version": "0.0.91",
"main": "lib/lib.js",
"typings": "lib/index.d.ts",
"scripts": {
Expand Down
3 changes: 1 addition & 2 deletions app/scripts/modules/amazon/src/aws.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { SUBNET_RENDERER } from './subnet/subnet.renderer';
import { SERVER_GROUP_DETAILS_MODULE } from './serverGroup/details/serverGroupDetails.module';
import { SERVER_GROUP_CONFIGURE_MODULE } from './serverGroup/configure/serverGroup.configure.aws.module';
import { COMMON_MODULE } from './common/common.module';
import { AMAZON_HELP } from './help/amazon.help';
import './help/amazon.help';

import { AmazonLoadBalancerClusterContainer } from './loadBalancer/AmazonLoadBalancerClusterContainer';
import { AmazonLoadBalancersTag } from './loadBalancer/AmazonLoadBalancersTag';
Expand Down Expand Up @@ -50,7 +50,6 @@ export const AMAZON_MODULE = 'spinnaker.amazon';
module(AMAZON_MODULE, [
AWS_REACT_MODULE,
CLOUD_PROVIDER_REGISTRY,
AMAZON_HELP,
AMAZON_APPLICATION_NAME_VALIDATOR,
require('./pipeline/stages/bake/awsBakeStage').name,
require('./pipeline/stages/cloneServerGroup/awsCloneServerGroupStage').name,
Expand Down
8 changes: 2 additions & 6 deletions app/scripts/modules/amazon/src/help/amazon.help.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { module } from 'angular';
import { HELP_CONTENTS_REGISTRY, HelpContentsRegistry } from '@spinnaker/core';
import { HelpContentsRegistry } from '@spinnaker/core';

const helpContents: { [key: string]: string } = {
'aws.associateElasticIp.elasticIp': `<p>(Optional) <b>Elastic IP</b> is an IP address that Spinnaker will associate with this cluster.</p>
Expand Down Expand Up @@ -113,7 +112,4 @@ const helpContents: { [key: string]: string } = {
<p>If the capacity has changed, this resize operation will be rejected.</p>`,
};

export const AMAZON_HELP = 'spinnaker.amazon.help.contents';
module(AMAZON_HELP, [HELP_CONTENTS_REGISTRY]).run((helpContentsRegistry: HelpContentsRegistry) => {
Object.keys(helpContents).forEach(key => helpContentsRegistry.register(key, helpContents[key]));
});
Object.keys(helpContents).forEach(key => HelpContentsRegistry.register(key, helpContents[key]));
3 changes: 1 addition & 2 deletions app/scripts/modules/appengine/src/appengine.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { APPENGINE_CACHE_CONFIGURER } from './cache/cacheConfigurer.service';
import { APPENGINE_COMPONENT_URL_DETAILS } from './common/componentUrlDetails.component';
import { APPENGINE_CONDITIONAL_DESCRIPTION_LIST_ITEM } from './common/conditionalDescriptionListItem.component';
import { APPENGINE_LOAD_BALANCER_CREATE_MESSAGE } from './common/loadBalancerMessage.component';
import { APPENGINE_HELP_CONTENTS_REGISTRY } from './helpContents/appengineHelpContents';
import './helpContents/appengineHelpContents';
import { APPENGINE_INSTANCE_DETAILS_CTRL } from './instance/details/details.controller';
import { APPENGINE_LOAD_BALANCER_MODULE } from './loadBalancer/loadBalancer.module';
import { APPENGINE_PIPELINE_MODULE } from './pipeline/pipeline.module';
Expand All @@ -33,7 +33,6 @@ module(APPENGINE_MODULE, [
APPENGINE_CLONE_SERVER_GROUP_CTRL,
APPENGINE_COMPONENT_URL_DETAILS,
APPENGINE_CONDITIONAL_DESCRIPTION_LIST_ITEM,
APPENGINE_HELP_CONTENTS_REGISTRY,
APPENGINE_INSTANCE_DETAILS_CTRL,
APPENGINE_LOAD_BALANCER_CREATE_MESSAGE,
APPENGINE_LOAD_BALANCER_MODULE,
Expand Down
265 changes: 130 additions & 135 deletions app/scripts/modules/appengine/src/helpContents/appengineHelpContents.ts
Original file line number Diff line number Diff line change
@@ -1,137 +1,132 @@
import { module } from 'angular';
import { HelpContentsRegistry } from '@spinnaker/core';

import { HELP_CONTENTS_REGISTRY, HelpContentsRegistry } from '@spinnaker/core';
const helpContents = [
{
key: 'appengine.serverGroup.gcs.repositoryUrl',
value: `The full URL to the GCS bucket or TAR file containing the source files for this deployment,
including 'gs://'. For example, <b>gs://my-bucket/my-app</b> or <b>gs://my-bucket/app.tar</b>.`,
},
{
key: 'appengine.serverGroup.git.repositoryUrl',
value: `The full URL to the git repository containing the source files for this deployment,
including protocol. For example, <b>https://github.com/spinnaker/deck.git<b/>`,
},
{
key: 'appengine.serverGroup.gitCredentialType',
value: `The credential type that will be used to access the git repository for this deployment.
You can configure these credentials alongside your App Engine credentials.`,
},
{
key: 'appengine.serverGroup.branch',
value: 'The name of the branch in the above git repository to be used for this deployment.',
},
{
key: 'appengine.serverGroup.applicationDirectoryRoot',
value: `(Optional) Path to the directory root of the application to be deployed,
starting from the root of the git repository. This is the directory from which
<code>gcloud app deploy</code> will be run.`,
},
{
key: 'appengine.serverGroup.configFilepaths',
value: `Paths to App Engine application configuration files, starting from the application directory root,
specified above. In most cases, this will be <code>app.yaml</code> or <code>cron.yaml</code>,
but could be <code>path/to/app.yaml</code> or <code>path/to/cron.yaml</code>.`,
},
{
key: 'appengine.serverGroup.configFiles',
value: `<p>(Optional) The contents of an App Engine config file (e.g., an <code>app.yaml</code> or
<code>cron.yaml</code> file). These files should not conflict with the config filepaths above:
if you include, for example, the contents of an <code>app.yaml</code>
file here, you should <b>not</b> specify the file path to an <code>app.yaml</code> above.<br></p>
<p>If this is a pipeline stage, you can use Spinnaker Pipeline Expressions here.</p>`,
},
{
key: 'appengine.serverGroup.configFilesRequired',
value: `<p>The contents of an App Engine config file (e.g., an <code>app.yaml</code> or
<code>cron.yaml</code> file).</p>
<p>An <code>app.yaml</code> file is required and must have <code>runtime: custom</code> in
order to deploy successfully.</p>
<p>If this is a pipeline stage, you can use Spinnaker Pipeline Expressions here.</p>`,
},
{
key: 'appengine.serverGroup.matchBranchOnRegex',
value: `(Optional) A Jenkins trigger may produce details from multiple repositories and branches.
Spinnaker will use the regex specified here to help resolve a branch for the deployment.
If Spinnaker cannot resolve exactly one branch from the trigger, this pipeline will fail.`,
},
{
key: 'appengine.serverGroup.promote',
value: 'If selected, the newly deployed server group will receive all traffic.',
},
{
key: 'appengine.serverGroup.stopPreviousVersion',
value: `If selected, the previously running server group in this server group\'s <b>service</b>
(Spinnaker load balancer) will be stopped. This option will be respected only if this server group will
be receiving all traffic and the previous server group is using manual scaling.`,
},
{
key: 'appengine.serverGroup.containerImageUrl',
value: `The full URL to the container image to use for deployment. The URL must be one of the valid GCR hostnames,
for example <b>gcr.io/my-project/image:tag</b>`,
},
{
key: 'appengine.loadBalancer.shardBy.cookie',
value:
'Diversion based on a specially named cookie, "GOOGAPPUID." The cookie must be set by the application itself or no diversion will occur.',
},
{
key: 'appengine.loadBalancer.shardBy.ip',
value: 'Diversion based on applying the modulus operation to a fingerprint of the IP address.',
},
{
key: 'appengine.loadBalancer.migrateTraffic',
value: `If selected, traffic will be gradually shifted to a single version. For gradual traffic migration,
the target version must be located within instances that are configured for
both warmup requests and automatic scaling.
Gradual traffic migration is not supported in the App Engine flexible environment.`,
},
{
key: 'appengine.loadBalancer.allocations',
value: 'An allocation is the percent of traffic directed to a server group.',
},
{
key: 'appengine.loadBalancer.textLocator',
value: `Either the name of a server group, or a Spinnaker Pipeline Expression
that resolves to the name of a server group.`,
},
{
key: 'appengine.instance.availability',
value: `
An instance's <b>availability</b> is determined by its version (Spinnaker server group).
<ul>
<li>Manual scaling versions use resident instances</li>
<li>Basic scaling versions use dynamic instances</li>
<li>Auto scaling versions use dynamic instances - but if you specify a number, N,
of minimum idle instances, the first N instances will be resident,
and additional dynamic instances will be created as necessary.
</li>
</ul>`,
},
{
key: 'appengine.instance.averageLatency',
value: 'Average latency over the last minute in milliseconds.',
},
{
key: 'appengine.instance.vmStatus',
value: 'Status of the virtual machine where this instance lives.',
},
{
key: 'appengine.instance.qps',
value: 'Average queries per second over the last minute.',
},
{
key: 'appengine.instance.errors',
value: 'Number of errors since this instance was started.',
},
{
key: 'appengine.instance.requests',
value: 'Number of requests since this instance was started.',
},
];

export const APPENGINE_HELP_CONTENTS_REGISTRY = 'spinnaker.appengine.helpContents.registry';
module(APPENGINE_HELP_CONTENTS_REGISTRY, [HELP_CONTENTS_REGISTRY]).run((helpContentsRegistry: HelpContentsRegistry) => {
const helpContents = [
{
key: 'appengine.serverGroup.gcs.repositoryUrl',
value: `The full URL to the GCS bucket or TAR file containing the source files for this deployment,
including 'gs://'. For example, <b>gs://my-bucket/my-app</b> or <b>gs://my-bucket/app.tar</b>.`,
},
{
key: 'appengine.serverGroup.git.repositoryUrl',
value: `The full URL to the git repository containing the source files for this deployment,
including protocol. For example, <b>https://github.com/spinnaker/deck.git<b/>`,
},
{
key: 'appengine.serverGroup.gitCredentialType',
value: `The credential type that will be used to access the git repository for this deployment.
You can configure these credentials alongside your App Engine credentials.`,
},
{
key: 'appengine.serverGroup.branch',
value: 'The name of the branch in the above git repository to be used for this deployment.',
},
{
key: 'appengine.serverGroup.applicationDirectoryRoot',
value: `(Optional) Path to the directory root of the application to be deployed,
starting from the root of the git repository. This is the directory from which
<code>gcloud app deploy</code> will be run.`,
},
{
key: 'appengine.serverGroup.configFilepaths',
value: `Paths to App Engine application configuration files, starting from the application directory root,
specified above. In most cases, this will be <code>app.yaml</code> or <code>cron.yaml</code>,
but could be <code>path/to/app.yaml</code> or <code>path/to/cron.yaml</code>.`,
},
{
key: 'appengine.serverGroup.configFiles',
value: `<p>(Optional) The contents of an App Engine config file (e.g., an <code>app.yaml</code> or
<code>cron.yaml</code> file). These files should not conflict with the config filepaths above:
if you include, for example, the contents of an <code>app.yaml</code>
file here, you should <b>not</b> specify the file path to an <code>app.yaml</code> above.<br></p>
<p>If this is a pipeline stage, you can use Spinnaker Pipeline Expressions here.</p>`,
},
{
key: 'appengine.serverGroup.configFilesRequired',
value: `<p>The contents of an App Engine config file (e.g., an <code>app.yaml</code> or
<code>cron.yaml</code> file).</p>
<p>An <code>app.yaml</code> file is required and must have <code>runtime: custom</code> in
order to deploy successfully.</p>
<p>If this is a pipeline stage, you can use Spinnaker Pipeline Expressions here.</p>`,
},
{
key: 'appengine.serverGroup.matchBranchOnRegex',
value: `(Optional) A Jenkins trigger may produce details from multiple repositories and branches.
Spinnaker will use the regex specified here to help resolve a branch for the deployment.
If Spinnaker cannot resolve exactly one branch from the trigger, this pipeline will fail.`,
},
{
key: 'appengine.serverGroup.promote',
value: 'If selected, the newly deployed server group will receive all traffic.',
},
{
key: 'appengine.serverGroup.stopPreviousVersion',
value: `If selected, the previously running server group in this server group\'s <b>service</b>
(Spinnaker load balancer) will be stopped. This option will be respected only if this server group will
be receiving all traffic and the previous server group is using manual scaling.`,
},
{
key: 'appengine.serverGroup.containerImageUrl',
value: `The full URL to the container image to use for deployment. The URL must be one of the valid GCR hostnames,
for example <b>gcr.io/my-project/image:tag</b>`,
},
{
key: 'appengine.loadBalancer.shardBy.cookie',
value:
'Diversion based on a specially named cookie, "GOOGAPPUID." The cookie must be set by the application itself or no diversion will occur.',
},
{
key: 'appengine.loadBalancer.shardBy.ip',
value: 'Diversion based on applying the modulus operation to a fingerprint of the IP address.',
},
{
key: 'appengine.loadBalancer.migrateTraffic',
value: `If selected, traffic will be gradually shifted to a single version. For gradual traffic migration,
the target version must be located within instances that are configured for
both warmup requests and automatic scaling.
Gradual traffic migration is not supported in the App Engine flexible environment.`,
},
{
key: 'appengine.loadBalancer.allocations',
value: 'An allocation is the percent of traffic directed to a server group.',
},
{
key: 'appengine.loadBalancer.textLocator',
value: `Either the name of a server group, or a Spinnaker Pipeline Expression
that resolves to the name of a server group.`,
},
{
key: 'appengine.instance.availability',
value: `
An instance's <b>availability</b> is determined by its version (Spinnaker server group).
<ul>
<li>Manual scaling versions use resident instances</li>
<li>Basic scaling versions use dynamic instances</li>
<li>Auto scaling versions use dynamic instances - but if you specify a number, N,
of minimum idle instances, the first N instances will be resident,
and additional dynamic instances will be created as necessary.
</li>
</ul>`,
},
{
key: 'appengine.instance.averageLatency',
value: 'Average latency over the last minute in milliseconds.',
},
{
key: 'appengine.instance.vmStatus',
value: 'Status of the virtual machine where this instance lives.',
},
{
key: 'appengine.instance.qps',
value: 'Average queries per second over the last minute.',
},
{
key: 'appengine.instance.errors',
value: 'Number of errors since this instance was started.',
},
{
key: 'appengine.instance.requests',
value: 'Number of requests since this instance was started.',
},
];

helpContents.forEach(entry => helpContentsRegistry.register(entry.key, entry.value));
});
helpContents.forEach(entry => HelpContentsRegistry.register(entry.key, entry.value));
3 changes: 1 addition & 2 deletions app/scripts/modules/azure/azure.module.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const angular = require('angular');

import { CLOUD_PROVIDER_REGISTRY, DeploymentStrategyRegistry } from '@spinnaker/core';

import { AZURE_HELP } from './help/azure.help';
import './help/azure.help';

// load all templates into the $templateCache
var templates = require.context('./', true, /\.html$/);
Expand All @@ -19,7 +19,6 @@ module.exports = angular
require('./pipeline/stages/disableAsg/azureDisableAsgStage.js').name,
require('./pipeline/stages/bake/azureBakeStage.js').name,
CLOUD_PROVIDER_REGISTRY,
AZURE_HELP,
require('./serverGroup/details/serverGroup.details.module.js').name,
require('./serverGroup/serverGroup.transformer.js').name,
require('./serverGroup/configure/wizard/CloneServerGroup.azure.controller.js').name,
Expand Down
8 changes: 2 additions & 6 deletions app/scripts/modules/azure/help/azure.help.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { module } from 'angular';
import { HELP_CONTENTS_REGISTRY, HelpContentsRegistry } from '@spinnaker/core';
import { HelpContentsRegistry } from '@spinnaker/core';

const helpContents: { [key: string]: string } = {
'azure.securityGroup.ingress.description': 'Friendly description of the rule you want to enable (limit 80 chars.)',
Expand Down Expand Up @@ -27,7 +26,4 @@ const helpContents: { [key: string]: string } = {
'azure.serverGroup.customData': 'Script or metadata to be injected into each instances.',
};

export const AZURE_HELP = 'spinnaker.azure.help.contents';
module(AZURE_HELP, [HELP_CONTENTS_REGISTRY]).run((helpContentsRegistry: HelpContentsRegistry) => {
Object.keys(helpContents).forEach(key => helpContentsRegistry.register(key, helpContents[key]));
});
Object.keys(helpContents).forEach(key => HelpContentsRegistry.register(key, helpContents[key]));
8 changes: 2 additions & 6 deletions app/scripts/modules/canary/canary.help.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { module } from 'angular';
import { HELP_CONTENTS_REGISTRY, HelpContentsRegistry } from 'core/help/helpContents.registry';
import { HelpContentsRegistry } from 'core/help/helpContents.registry';

const helpContents: { [key: string]: string } = {
'pipeline.config.canary.clusterPairs': `
Expand Down Expand Up @@ -34,7 +33,4 @@ const helpContents: { [key: string]: string } = {
'<p>Uses the global atlas dataset instead of the region specific dataset for ACA</p>',
};

export const CANARY_HELP = 'spinnaker.core.canary.help.contents';
module(CANARY_HELP, [HELP_CONTENTS_REGISTRY]).run((helpContentsRegistry: HelpContentsRegistry) => {
Object.keys(helpContents).forEach(key => helpContentsRegistry.register(key, helpContents[key]));
});
Object.keys(helpContents).forEach(key => HelpContentsRegistry.register(key, helpContents[key]));
8 changes: 2 additions & 6 deletions app/scripts/modules/canary/canary.module.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { module } from 'angular';

import { CANARY_HELP } from './canary.help';
import './canary.help';

import './canary.less';

Expand All @@ -11,8 +11,4 @@ templates.keys().forEach(function(key) {
});

export const CANARY_MODULE = 'spinnaker.canary';
module(CANARY_MODULE, [
require('./acaTask/acaTaskStage.module').name,
require('./canary/canaryStage.module').name,
CANARY_HELP,
]);
module(CANARY_MODULE, [require('./acaTask/acaTaskStage.module').name, require('./canary/canaryStage.module').name]);
Loading

0 comments on commit 4b39044

Please sign in to comment.