Skip to content

Commit

Permalink
fix(provider/kubernetes): fix runJob exec details (#4497)
Browse files Browse the repository at this point in the history
when making the switch to multi-container jobs, i forgot to update the
execution details
  • Loading branch information
ethanfrogers committed Nov 20, 2017
1 parent 595cdcd commit 57fd96b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 6 deletions.
Expand Up @@ -10,6 +10,11 @@ module.exports = angular

$scope.configSections = ['runJobConfig', 'taskStatus'];

// if the stage is pre-multi-containers
if ($scope.stage.context.container) {
$scope.stage.context.containers = [$scope.stage.context.container];
}

let initialized = () => {
$scope.detailsSection = $stateParams.details;
};
Expand Down
Expand Up @@ -9,12 +9,14 @@
<dt>Namespace</dt>
<dd>{{stage.context.namespace}}</dd>
<dt>Image</dt>
<dd ng-if="!stage.context.container.imageDescription.fromTrigger">
{{[stage.context.container.imageDescription.repository, stage.context.container.imageDescription.tag].join(':')}}
</dd>
<dd ng-if="stage.context.container.imageDescription.fromTrigger">
{{[stage.context.container.imageDescription.repository, execution.trigger.tag].join(':')}}
</dd>
<span ng-repeat="container in stage.context.containers">
<dd ng-if="!container.imageDescription.fromTrigger">
{{[container.imageDescription.repository, container.imageDescription.tag].join(':')}}
</dd>
<dd ng-if="container.imageDescription.fromTrigger">
{{[container.imageDescription.repository, execution.trigger.tag].join(':')}}
</dd>
</span>
</dl>
</div>
</div>
Expand Down

0 comments on commit 57fd96b

Please sign in to comment.