feat(core): remove 'N/A' if no server group sequence exists (#4973)

spinnaker · Mar 8, 2018 · 5a7eed5 · 5a7eed5
1 parent fab805f
commit 5a7eed5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/scripts/modules/core/src/naming/naming.service.spec.ts b/app/scripts/modules/core/src/naming/naming.service.spec.ts
@@ -63,7 +63,7 @@ describe('namingService', function () {
     expect(this.namingService.getSequence(0)).toBe('v000');
     expect(this.namingService.getSequence(10)).toBe('v010');
     expect(this.namingService.getSequence(100)).toBe('v100');
-    expect(this.namingService.getSequence(null)).toBe('N/A');
-    expect(this.namingService.getSequence(undefined)).toBe('N/A');
+    expect(this.namingService.getSequence(null)).toBe(null);
+    expect(this.namingService.getSequence(undefined)).toBe(null);
   });
 });
diff --git a/app/scripts/modules/core/src/naming/naming.service.ts b/app/scripts/modules/core/src/naming/naming.service.ts
@@ -73,7 +73,7 @@ export class NamingService {
 
   public getSequence(monikerSequence: number): string {
     if (isNil(monikerSequence)) {
-      return 'N/A';
+      return null;
     } else {
       return `v${padStart(monikerSequence.toString(), 3, '0')}`;
     }