Skip to content

Commit

Permalink
chore(typescript): Switch module from 'commonjs' to 'esnext' to emit …
Browse files Browse the repository at this point in the history
…raw dynamic 'import()'
  • Loading branch information
christopherthielen committed Feb 5, 2019
1 parent cf861ba commit 5c49dd2
Show file tree
Hide file tree
Showing 13 changed files with 21 additions and 32 deletions.
2 changes: 1 addition & 1 deletion app/scripts/modules/amazon/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/appengine/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/cloudfoundry/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
21 changes: 5 additions & 16 deletions app/scripts/modules/core/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"jsx": "react",
"lib": [
"es2016",
"dom"
],
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand All @@ -30,21 +27,13 @@
"inlineSources": true,
"strictNullChecks": false, // should really get to a place where we can turn this on
"target": "es6",
"typeRoots": [
"../../../../node_modules/@types"
],
"typeRoots": ["../../../../node_modules/@types"],
"paths": {
"@spinnaker/core": ["."],
"core/*": ["*"],
"core": ["."]
}
},
"include": [
"src/**/*.ts",
"src/**/*.tsx"
],
"exclude": [
"./lib",
"**/*.spec.*"
]
"include": ["src/**/*.ts", "src/**/*.tsx"],
"exclude": ["./lib", "**/*.spec.*"]
}
2 changes: 1 addition & 1 deletion app/scripts/modules/docker/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/ecs/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/google/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/kubernetes/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2017", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/openstack/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/oracle/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/modules/titus/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"jsx": "react",
"lib": ["es2016", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down
10 changes: 5 additions & 5 deletions jsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"purpose": "This file is used to support Microsoft Visual Studio Code users. See http://blogs.msdn.com/b/vscode/archive/2015/07/06/vs-code-es6.aspx for more details.",
"compilerOptions": {
"target": "ES6",
"module": "commonjs"
}
"purpose": "This file is used to support Microsoft Visual Studio Code users. See http://blogs.msdn.com/b/vscode/archive/2015/07/06/vs-code-es6.aspx for more details.",
"compilerOptions": {
"target": "ES6",
"module": "esnext"
}
}
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"jsx": "react",
"lib": ["es2017", "dom"],
"moduleResolution": "node",
"module": "commonjs",
"module": "esnext",
"noEmitHelpers": false,
"noImplicitAny": true,
"noImplicitReturns": true,
Expand Down

0 comments on commit 5c49dd2

Please sign in to comment.