Merge branch 'master' into titus-bake-info

app/scripts/modules/amazon/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/amazon",
   "license": "Apache-2.0",
-  "version": "0.0.289",
+  "version": "0.0.290",
   "main": "lib/lib.js",
   "typings": "lib/index.d.ts",
   "scripts": {

app/scripts/modules/amazon/src/serverGroup/configure/wizard/pages/ServerGroupBasicSettings.tsx

@@ -103,9 +103,8 @@ export class ServerGroupBasicSettings
       AWSProviderSettings?.serverGroups?.enableIPv6 &&
       AWSProviderSettings?.serverGroups?.setIPv6InTest &&
       accountDetails.environment === 'test';
-    if (enableIPv6InTest) {
-      setFieldValue('associateIPv6Address', enableIPv6InTest);
-    }
+
+    setFieldValue('associateIPv6Address', enableIPv6InTest);
   };
 
   private regionUpdated = (region: string): void => {

app/scripts/modules/core/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/core",
   "license": "Apache-2.0",
-  "version": "0.0.547",
+  "version": "0.0.549",
   "main": "lib/lib.js",
   "typings": "lib/index.d.ts",
   "scripts": {

app/scripts/modules/core/src/application/ApplicationFreshIcon.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 
 import { Overridable } from '../overrideRegistry/Overridable';
 
-import { Illustration } from '../presentation';
+import { Illustration } from '@spinnaker/presentation';
 
 @Overridable('applicationIcon')
 export class ApplicationFreshIcon extends React.Component<{}> {

app/scripts/modules/core/src/application/nav/AppRefresherIcon.tsx

@@ -3,9 +3,11 @@ import { $window } from 'ngimport';
 
 import { ApplicationFreshIcon } from '../ApplicationFreshIcon';
 import { SchedulerFactory } from 'core/scheduler';
-import { Illustration, Tooltip } from 'core/presentation';
+import { Tooltip } from 'core/presentation';
 import { relativeTime, timestamp } from 'core/utils/timeFormatters';
 
+import { Illustration } from '@spinnaker/presentation';
+
 export interface IAppRefreshIconProps {
   appName: string;
   lastRefresh: number;

app/scripts/modules/core/src/application/nav/ApplicationNavigation.tsx

@@ -6,7 +6,7 @@ import { SETTINGS } from 'core/config/settings';
 
 import { AppRefresher } from './AppRefresher';
 import { NavSection } from './NavSection';
-import { Icon, Tooltip, useIsMobile, usePrevious } from '../../presentation';
+import { Tooltip, useIsMobile, usePrevious } from '../../presentation';
 
 import { navigationCategoryRegistry } from './navigationCategory.registry';
 import { verticalNavExpandedAtom } from './navAtoms';
@@ -16,6 +16,8 @@ import { ApplicationDataSource } from '../service/applicationDataSource';
 
 import './verticalNav.less';
 
+import { Icon } from '@spinnaker/presentation';
+
 export interface IApplicationNavigationProps {
   app: Application;
 }

app/scripts/modules/core/src/application/nav/NavItem.tsx

@@ -2,13 +2,15 @@ import React from 'react';
 import { useRecoilValue } from 'recoil';
 
 import { DataSourceNotifications } from 'core/entityTag/notifications/DataSourceNotifications';
-import { Icon, Tooltip, useDataSource } from '../../presentation';
+import { Tooltip, useDataSource } from '../../presentation';
 import { verticalNavExpandedAtom } from './navAtoms';
 
 import { ApplicationDataSource } from '../service/applicationDataSource';
 import { Application } from '../application.model';
 import { IEntityTags } from '../../domain';
 
+import { Icon } from '@spinnaker/presentation';
+
 export interface INavItemProps {
   app: Application;
   dataSource: ApplicationDataSource;

app/scripts/modules/core/src/ci/CIReader.ts

@@ -21,12 +21,12 @@ function transformBuildToUIFormat(build: ICiBuildAPI) {
   const startTime = parseInt(properties.startedTs, 10);
 
   const transformedBuild = {
-    author: scm[0].committer,
+    author: scm.length == 0 ? '' : scm[0].committer,
     artifacts: artifacts.map((artifact) => ({ name: artifact.fileName, url: artifact.displayPath })),
-    branchName: scm[0].branch,
-    commitId: scm[0].sha1.substr(0, 7), // naive shortening of the commit hash.
-    commitLink: scm[0].compareUrl,
-    commitMessage: scm[0].message,
+    branchName: scm.length == 0 ? '' : scm[0].branch,
+    commitId: scm.length == 0 ? '' : scm[0].sha1.substr(0, 7), // naive shortening of the commit hash.
+    commitLink: scm.length == 0 ? '' : scm[0].compareUrl,
+    commitMessage: scm.length == 0 ? '' : scm[0].message,
     duration: build.duration,
     fullDisplayName: build.fullDisplayName,
     id: build.id,

app/scripts/modules/core/src/ci/igor.service.ts

@@ -29,15 +29,15 @@ export class IgorService {
   }
 
   public static listJobsForMaster(master: string): PromiseLike<string[]> {
-    return REST('/v2/builds').path(master, 'jobs').get();
+    return REST('/v3/builds').path(master, 'jobs').get();
   }
 
   public static listBuildsForJob(master: string, job: string): PromiseLike<IBuild[]> {
-    return REST('/v2/builds').path(master, 'builds', job).get();
+    return REST('/v3/builds').path(master, 'builds').query({ job }).get();
   }
 
   public static getJobConfig(master: string, job: string): PromiseLike<IJobConfig> {
-    return REST('/v2/builds').path(master, 'jobs', job).get();
+    return REST('/v3/builds').path(master, 'job').query({ job }).get();
   }
 
   public static getGcbAccounts(): PromiseLike<string[]> {

app/scripts/modules/core/src/header/SpinnakerHeader.tsx

@@ -9,10 +9,10 @@ import { CollapsibleSectionStateCache } from 'core/cache';
 import { Overridable } from 'core/overrideRegistry';
 import { GlobalSearch } from 'core/search/global/GlobalSearch';
 import { HelpMenu } from 'core/help/HelpMenu';
-import { Icon } from 'core/presentation';
-
 import './SpinnakerHeader.css';
 
+import { Icon } from '@spinnaker/presentation';
+
 @UIRouterContext
 @Overridable('spinnakerHeader')
 export class SpinnakerHeader extends React.Component<{}, {}> {

app/scripts/modules/core/src/managed/Button.tsx

@@ -1,9 +1,9 @@
 import React from 'react';
 
-import { Icon, IconNames } from '../presentation';
-
 import './Button.less';
 
+import { Icon, IconNames } from '@spinnaker/presentation';
+
 const DEFAULT_APPEARANCE = 'secondary';
 
 export interface IButtonProps {

app/scripts/modules/core/src/managed/ColumnHeader.tsx

@@ -1,9 +1,9 @@
 import React from 'react';
 
-import { Icon, IconNames } from '../presentation';
-
 import './ColumnHeader.less';
 
+import { Icon, IconNames } from '@spinnaker/presentation';
+
 export interface IColumnHeaderProps {
   text: string;
   icon: IconNames;

app/scripts/modules/core/src/managed/EnvironmentsHeader.tsx

@@ -2,11 +2,11 @@ import React from 'react';
 import { Dropdown } from 'react-bootstrap';
 
 import { Application } from '../application';
-import { Illustration, IllustrationName } from '../presentation';
 import { showToggleManagedResourceModal } from './ToggleManagedResourceForApplication';
-
 import './EnvironmentsHeader.less';
 
+import { Illustration, IllustrationName } from '@spinnaker/presentation';
+
 interface IEnvironmentsHeaderProps {
   app: Application;
   resourceInfo: { managed: number; total: number };

app/scripts/modules/core/src/managed/ManagedResourceObject.tsx

@@ -2,17 +2,17 @@ import React, { memo } from 'react';
 import { useSref } from '@uirouter/react';
 
 import { Application } from 'core/application';
-import { Icon } from '../presentation';
 import { IManagedResourceSummary, IManagedEnvironmentSummary, IManagedArtifactSummary } from '../domain/IManagedEntity';
-
 import { getKindName } from './ManagedReader';
+
 import { ObjectRow } from './ObjectRow';
 import { AnimatingPill, Pill } from './Pill';
 import { getResourceIcon, getExperimentalDisplayLink } from './resources/resourceRegistry';
 import { getArtifactVersionDisplayName } from './displayNames';
 import { StatusBubble } from './StatusBubble';
 import { viewConfigurationByStatus } from './managedResourceStatusConfig';
 import { ManagedResourceStatusPopover } from './ManagedResourceStatusPopover';
+import { Icon } from '@spinnaker/presentation';
 
 export interface IManagedResourceObjectProps {
   application: Application;

app/scripts/modules/core/src/managed/ManagedResourceStatusIndicator.tsx

@@ -3,11 +3,11 @@ import classNames from 'classnames';
 
 import { IManagedResourceSummary } from 'core/domain';
 import { Application } from 'core/application';
-import { Icon } from 'core/presentation';
-
 import { viewConfigurationByStatus } from './managedResourceStatusConfig';
+
 import { ManagedResourceStatusPopover } from './ManagedResourceStatusPopover';
 import './ManagedResourceStatusIndicator.less';
+import { Icon } from '@spinnaker/presentation';
 
 export interface IManagedResourceStatusIndicatorProps {
   shape: 'square' | 'circle';

app/scripts/modules/core/src/managed/ObjectRow.tsx

@@ -1,9 +1,9 @@
 import React from 'react';
 
-import { Icon, IconNames } from '../presentation';
-
 import './ObjectRow.less';
 
+import { Icon, IconNames } from '@spinnaker/presentation';
+
 interface IObjectRowProps {
   content?: JSX.Element;
   icon: IconNames;

app/scripts/modules/core/src/managed/StatusBubble.tsx

@@ -2,10 +2,10 @@ import React, { ReactNode, memo } from 'react';
 import { useTransition, animated } from 'react-spring';
 import classNames from 'classnames';
 
-import { Icon, IconNames } from '../presentation';
-
 import './StatusBubble.less';
 
+import { Icon, IconNames } from '@spinnaker/presentation';
+
 const QUANITITY_SIZES = ['small', 'medium', 'large', 'extraLarge'];
 
 export interface IStatusBubbleProps {

app/scripts/modules/core/src/managed/StatusCard.tsx

@@ -2,13 +2,13 @@ import React from 'react';
 import classNames from 'classnames';
 import { DateTime } from 'luxon';
 
-import { IconNames } from '../presentation';
-
 import { StatusBubble } from './StatusBubble';
-import { RelativeTimestamp } from './RelativeTimestamp';
 
+import { RelativeTimestamp } from './RelativeTimestamp';
 import './StatusCard.less';
 
+import { IconNames } from '@spinnaker/presentation';
+
 export interface IStatusCardProps {
   appearance: 'future' | 'neutral' | 'info' | 'progress' | 'success' | 'warning' | 'error' | 'archived';
   background?: boolean;

app/scripts/modules/core/src/managed/ToggleManagedResourceForApplication.tsx

@@ -4,8 +4,6 @@ import ReactGA from 'react-ga';
 import { Application } from '../application';
 import { Button } from './Button';
 import {
-  Illustration,
-  IllustrationName,
   IModalComponentProps,
   ModalBody,
   ModalFooter,
@@ -15,6 +13,8 @@ import {
 } from '../presentation';
 import { ManagedWriter } from './ManagedWriter';
 
+import { Illustration, IllustrationName } from '@spinnaker/presentation';
+
 const logClick = (label: string, application: string) =>
   ReactGA.event({
     category: 'Environments - toggle application management modal',

app/scripts/modules/core/src/managed/artifactDetail/ArtifactDetailHeader.tsx

@@ -1,8 +1,8 @@
 import React from 'react';
 
-import { Icon } from '../../presentation';
-import { IManagedArtifactVersion } from '../../domain';
+import { Icon } from '@spinnaker/presentation';
 
+import { IManagedArtifactVersion } from '../../domain';
 import { getArtifactVersionDisplayName } from '../displayNames';
 
 import './ArtifactDetailHeader.less';

app/scripts/modules/core/src/managed/artifactDetail/MarkArtifactAsBadModal.tsx

@@ -2,6 +2,8 @@ import React, { memo, useCallback, useEffect } from 'react';
 import ReactGA from 'react-ga';
 import { Option } from 'react-select';
 
+import { Illustration } from '@spinnaker/presentation';
+
 import {
   IModalComponentProps,
   ModalHeader,
@@ -13,7 +15,6 @@ import {
   showModal,
   SpinFormik,
   ValidationMessage,
-  Illustration,
 } from '../../presentation';
 import { HelpField } from '../../help';
 import { IManagedArtifactVersion, IManagedResourceSummary } from '../../domain';

app/scripts/modules/core/src/managed/artifactDetail/PinArtifactModal.tsx

@@ -2,6 +2,8 @@ import React, { memo, useCallback, useEffect } from 'react';
 import ReactGA from 'react-ga';
 import { Option } from 'react-select';
 
+import { Illustration } from '@spinnaker/presentation';
+
 import {
   IModalComponentProps,
   ModalHeader,
@@ -13,7 +15,6 @@ import {
   showModal,
   SpinFormik,
   ValidationMessage,
-  Illustration,
 } from '../../presentation';
 import { HelpField } from '../../help';
 import { IManagedArtifactVersion, IManagedResourceSummary } from '../../domain';

app/scripts/modules/core/src/managed/artifactDetail/UnpinArtifactModal.tsx

@@ -1,6 +1,8 @@
 import React, { memo, useEffect, useState } from 'react';
 import ReactGA from 'react-ga';
 
+import { Illustration } from '@spinnaker/presentation';
+
 import {
   IModalComponentProps,
   ModalHeader,
@@ -9,7 +11,6 @@ import {
   showModal,
   ValidationMessage,
   IRequestStatus,
-  Illustration,
 } from '../../presentation';
 import { IManagedArtifactVersion, IManagedResourceSummary } from '../../domain';
 import { Application } from '../../application';

app/scripts/modules/core/src/managed/artifactDetail/VersionStateCard.tsx

@@ -1,8 +1,10 @@
 import React, { memo, useMemo } from 'react';
 import { DateTime } from 'luxon';
 
+import { IconNames } from '@spinnaker/presentation';
+
 import { IManagedArtifactVersion } from '../../domain';
-import { Markdown, IconNames } from '../../presentation';
+import { Markdown } from '../../presentation';
 
 import { getArtifactVersionDisplayName } from '../displayNames';
 import { StatusCard, IStatusCardProps } from '../StatusCard';

app/scripts/modules/core/src/managed/artifactDetail/constraints/constraintRegistry.tsx

@@ -1,13 +1,14 @@
 import React from 'react';
 import { DateTime } from 'luxon';
 
+import { IconNames } from '@spinnaker/presentation';
+
 import {
   IStatefulConstraint,
   StatefulConstraintStatus,
   IStatelessConstraint,
   IManagedArtifactVersionEnvironment,
 } from '../../../domain';
-import { IconNames } from '../../../presentation';
 
 const NO_FAILURE_MESSAGE = 'no details available';
 const UNKNOWN_CONSTRAINT_ICON = 'mdConstraintGeneric';

app/scripts/modules/core/src/managed/artifactsList/ArtifactsList.tsx

@@ -2,13 +2,14 @@ import React, { useMemo, useEffect, useRef, useState } from 'react';
 import classNames from 'classnames';
 import { DateTime } from 'luxon';
 
+import { Icon, IconNames } from '@spinnaker/presentation';
+
 import {
   IManagedArtifactSummary,
   IManagedArtifactVersion,
   IStatefulConstraint,
   StatefulConstraintStatus,
 } from '../../domain/IManagedEntity';
-import { Icon, IconNames } from '../../presentation';
 
 import { isConstraintSupported, getConstraintIcon } from '../artifactDetail/constraints/constraintRegistry';
 

app/scripts/modules/core/src/managed/environment/EnvironmentRow.tsx

@@ -1,11 +1,10 @@
 import React, { useState } from 'react';
 import classNames from 'classnames';
 
-import { IManagedResourceSummary, IManagedEnvironmentSummary } from '../../domain';
-import { Icon } from '../../presentation';
+import { Icon } from '@spinnaker/presentation';
 
+import { IManagedResourceSummary, IManagedEnvironmentSummary } from '../../domain';
 import { StatusBubble } from '../StatusBubble';
-
 import { EnvironmentBadge } from '../EnvironmentBadge';
 import { useEnvironmentTypeFromResources } from '../useEnvironmentTypeFromResources.hooks';
 

app/scripts/modules/core/src/managed/managedResourceStatusConfig.tsx

@@ -3,7 +3,7 @@ import ReactGA from 'react-ga';
 
 import { Application } from 'core/application';
 import { IManagedResourceSummary, ManagedResourceStatus } from 'core/domain';
-import { IconNames } from 'core/presentation';
+import { IconNames } from '@spinnaker/presentation';
 
 interface IViewConfiguration {
   appearance: 'info' | 'warning' | 'error';