fix(core): correct category on recently viewed analytics events (#4933)

app/scripts/modules/core/src/search/infrastructure/RecentlyViewedItems.tsx

@@ -11,9 +11,9 @@ import { ISearchResult, ISearchResultPodData, SearchResultPods } from './SearchR
 
 export interface IChildComponentProps {
   results: ISearchResultPodData[];
-  onResultClick: (categoryName: string) => void;
   onRemoveItem?: (categoryName: string, itemId: string) => void;
   onRemoveProject?: (projectId: string) => void;
+  onResultClick: (categoryName: string) => void;
 }
 
 export interface IRecentlyViewedItemsProps {
@@ -86,7 +86,7 @@ export class RecentlyViewedItems extends React.Component<IRecentlyViewedItemsPro
   }
 
   private handleResultClick(categoryName: string): void {
-    ReactGA.event({ category: 'Global Search', action: `Recent item selected from ${categoryName}` });
+    ReactGA.event({ category: 'Primary Search', action: `Recent item selected from ${categoryName}` });
   }
 
   public render() {
@@ -97,17 +97,17 @@ export class RecentlyViewedItems extends React.Component<IRecentlyViewedItemsPro
         <Component
           results={this.state.recentItems}
           onRemoveItem={this.handleRemoveItem}
-          onResultClick={this.handleResultClick}
           onRemoveProject={this.handleRemoveProject}
+          onResultClick={this.handleResultClick}
         />
        ) : (
         // Once RecentlyViewedItems is no longer rendered as part of any angular
         // templates, we can stop defaulting to SearchResultPods and require a component.
         <SearchResultPods
           results={this.state.recentItems}
           onRemoveItem={this.handleRemoveItem}
-          onResultClick={this.handleResultClick}
           onRemoveProject={this.handleRemoveProject}
+          onResultClick={this.handleResultClick}
         />
        )
     );

app/scripts/modules/core/src/search/infrastructure/search.infrastructure.module.js

@@ -5,7 +5,6 @@ import { RECENTLY_VIEWED_ITEMS_COMPONENT } from './recentlyViewedItems.component
 import { SEARCH_COMPONENT } from '../widgets/search.component';
 import { SEARCH_INFRASTRUCTURE_V2_CONTROLLER } from './infrastructureSearchV2.component';
 import { SEARCH_RESULT_COMPONENT } from './searchResult.component';
-import { SEARCH_RESULT_PODS_COMPONENT } from './searchResultPods.component';
 
 import './infrastructure.less';
 
@@ -17,5 +16,4 @@ module(SEARCH_INFRASTRUCTURE, [
   SEARCH_COMPONENT,
   SEARCH_INFRASTRUCTURE_V2_CONTROLLER,
   SEARCH_RESULT_COMPONENT,
-  SEARCH_RESULT_PODS_COMPONENT,
 ]);