fix(provider/cf): allow only alphanumeric and '_' for env variable keys

Co-Authored-By: Stu Pollock <spollock@pivotal.io>
spinnaker · Nov 9, 2018 · 90e6864 · 90e6864
1 parent a6f6b07
commit 90e6864
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/...dules/cloudfoundry/src/serverGroup/configure/wizard/sections/configurationSettings.cf.tsx b/...dules/cloudfoundry/src/serverGroup/configure/wizard/sections/configurationSettings.cf.tsx
@@ -654,6 +654,14 @@ class ConfigurationSettingsImpl extends React.Component<ICloudFoundryServerGroup
             errors.manifest = errors.manifest || {};
             errors.manifest.env = `An environment variable was not set`;
           } else {
+            if (e.key) {
+              const validKeyRegex = /^\w+$/g;
+              if (!validKeyRegex.exec(e.key)) {
+                errors.manifest = errors.manifest || {};
+                errors.manifest.env =
+                  `'` + e.key + `' is an invalid environment variable name and must be alphanumeric`;
+              }
+            }
             const value = existingKeys[e.key];
             if (!value) {
               existingKeys[e.key] = e.value;