feat(amazon/serverGroup): Change default capacity constraint to off (#…

…5001)

Since adding a capacity constraint option for server group resizes, we've realized that for the majority of ad-hoc resizes capacity constraints are not a helpful protection. In the worst case, this can lead to urgent resizes being delayed due to the initial attempt failing and the user needing to go back and retry with capacity constraints turned off.

For now, the fastest path to fixing this problem is to change the default state so that capacity constraints are opt-in. Going forward, there may be more we can do to simplify along the lines of better messaging and/or allowing users to choose a single capacity setting they'd like to affect (i.e. only modify desired while leaving other processes free to modify min/max).

app/scripts/modules/amazon/src/serverGroup/details/resize/resizeServerGroup.controller.js

@@ -26,13 +26,7 @@ module.exports = angular.module('spinnaker.amazon.serverGroup.details.resize.con
 
     $scope.command = angular.copy($scope.currentSize);
     $scope.command.advancedMode = serverGroup.asg.minSize !== serverGroup.asg.maxSize;
-    $scope.command.constraints = {
-      capacity: {
-        min: serverGroup.asg.minSize,
-        max: serverGroup.asg.maxSize,
-        desired: serverGroup.asg.desiredCapacity
-      }
-    };
+    $scope.command.constraints = {};
 
     if (application && application.attributes) {
       if (application.attributes.platformHealthOnlyShowOverride && application.attributes.platformHealthOnly) {