fix(publishing): pass --yes to lerna publish from-git (#9478)

Also re-organize the workflow steps

.github/workflows/publish.yml

@@ -21,15 +21,19 @@ jobs:
         with:
           node-version: 12.16.0
 
-      - name: git - configure commit user
+      - name: git - tag bumped packages
+        id: tag
         run: |
           git config user.name spinnakerbot
           git config user.email spinnakerbot@spinnaker.io
+          scripts/gha_tag_bumped_packages.sh
 
       - name: publish packages to npm
+        if: ${{ steps.tag.outputs.tagged == 'true' }}
         run: |
           npm config set //registry.npmjs.org/:_authToken=$NPM_AUTH_TOKEN
-          scripts/gha_publish.sh
+          yarn --frozen-lockfile
+          npx lerna publish from-git --yes
         env:
           CI: true
           NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

scripts/gha_publish.sh → scripts/gha_tag_bumped_packages.sh

@@ -1,7 +1,5 @@
 #!/bin/bash
 
-PACKAGES_TO_PUBLISH="";
-
 # Run this script from the 'deck/packages' directory
 cd "$(dirname "$0")/../packages" || exit 255
 
@@ -10,7 +8,7 @@ if [ "x${GITHUB_ACTIONS}" != "xtrue" ] ; then
   exit 2
 fi
 
-BUMPS=no
+TAGGED=false
 
 # Determine what packages were bumped in the pushed commit and tag them
 for PACKAGEJSON in */package.json ; do
@@ -20,16 +18,9 @@ for PACKAGEJSON in */package.json ; do
     TAG=$(jq -r '.name + "@" + .version' < $PACKAGEJSON)
     git tag -a $TAG -m "Publish $TAG to NPM"
     git push origin $TAG
-    BUMPS=yes
+    TAGGED=true
   fi
 done
 
-if [ "${BUMPS}" == "no" ] ; then
-  echo "Nothing to publish."
-  exit 0
-fi
-
-echo "Deck package publisher ---> yarn"
-yarn
-
-npx lerna publish from-git
+## Github Action Step output variable: tagged
+echo ::set-output name=tagged::$TAGGED