fix(core): do not automatically inject parameterConfig on pipelines (#…

…7009)
spinnaker · May 16, 2019 · d805c18 · d805c18
1 parent 1c8b570
commit d805c18
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/app/scripts/modules/core/src/pipeline/config/parameters/Parameters.tsx b/app/scripts/modules/core/src/pipeline/config/parameters/Parameters.tsx
@@ -76,7 +76,7 @@ export class Parameters extends React.Component<IParametersProps, IParametersSta
           togglePins={this.togglePins}
           removeParameter={this.removeParameter}
           updateParameter={this.updateParameter}
-          isMultiple={parameters.length > 1}
+          isMultiple={parameters && parameters.length > 1}
           onSortEnd={this.handleSortEnd}
           lockAxis={'y'}
           useDragHandle={true}

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/triggers.directive.js b/app/scripts/modules/core/src/pipeline/config/triggers/triggers.directive.js
@@ -75,9 +75,6 @@ module.exports = angular
 
       this.checkFeatureFlag = flag => !!SETTINGS.feature[flag];
 
-      //Call back function for full controlled react component
-      $scope.pipeline.parameterConfig = $scope.pipeline.parameterConfig || [];
-
       $scope.addParameter = () => {
         if (!$scope.pipeline.parameterConfig) {
           $scope.pipeline.parameterConfig = [];