fix(artifacts): replace legacy-only Find Artifacts UI with Produces A…

…rtifacts (#8160)
spinnaker · Apr 13, 2020 · df9978f · df9978f
1 parent f7be1d4
commit df9978f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 30 deletions.
diff --git a/.../pipeline/config/stages/findArtifactFromExecution/findArtifactFromExecution.controller.ts b/.../pipeline/config/stages/findArtifactFromExecution/findArtifactFromExecution.controller.ts
@@ -1,13 +1,6 @@
 import { IController, IScope } from 'angular';
 
-import {
-  ApplicationReader,
-  ExpectedArtifactService,
-  IExpectedArtifact,
-  IPipeline,
-  IStage,
-  PipelineConfigService,
-} from 'core';
+import { ApplicationReader, ExpectedArtifactService, IExpectedArtifact, IPipeline, PipelineConfigService } from 'core';
 
 export interface IFindArtifactFromExecutionStage {
   application: string;
@@ -84,12 +77,4 @@ export class FindArtifactFromExecutionCtrl implements IController {
   public onApplicationSelect() {
     this.loadPipelines();
   }
-
-  public addExpectedArtifact = () => {
-    ExpectedArtifactService.addNewArtifactTo(this.stage);
-  };
-
-  public removeExpectedArtifact = (stage: IStage, expectedArtifact: IExpectedArtifact) => {
-    stage.expectedArtifacts = stage.expectedArtifacts.filter((a: IExpectedArtifact) => a.id !== expectedArtifact.id);
-  };
 }
diff --git a/...src/pipeline/config/stages/findArtifactFromExecution/findArtifactFromExecutionConfig.html b/...src/pipeline/config/stages/findArtifactFromExecution/findArtifactFromExecutionConfig.html
@@ -41,18 +41,4 @@ <h4>Execution Options</h4>
       <label> <input type="checkbox" ng-model="ctrl.stage.executionOptions.running" /> that are still running </label>
     </div>
   </div>
-  <h4>Match Artifacts</h4>
-  <expected-artifact
-    ng-repeat="artifact in ctrl.stage.expectedArtifacts"
-    context="ctrl.stage"
-    expected-artifact="artifact"
-    remove-expected-artifact="ctrl.removeExpectedArtifact"
-  />
-  <div class="row">
-    <div class="col-md-12">
-      <button class="btn btn-block btn-add-trigger add-new" ng-click="ctrl.addExpectedArtifact()">
-        <span class="glyphicon glyphicon-plus-sign"></span> Add Artifact
-      </button>
-    </div>
-  </div>
 </div>
diff --git a/...re/src/pipeline/config/stages/findArtifactFromExecution/findArtifactFromExecutionStage.ts b/...re/src/pipeline/config/stages/findArtifactFromExecution/findArtifactFromExecutionStage.ts
@@ -29,6 +29,7 @@ module(FIND_ARTIFACT_FROM_EXECUTION_STAGE, [])
           { type: 'requiredField', fieldName: 'pipeline', fieldLabel: 'Pipeline' },
           { type: 'requiredField', fieldName: 'application', fieldLabel: 'Application' },
         ],
+        producesArtifacts: true,
       });
     }
   })