fix(amazon): do not set target group errors to falsy values (#7050)

spinnaker · May 22, 2019 · e259625 · e259625
1 parent d794173
commit e259625
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/scripts/modules/amazon/src/loadBalancer/configure/application/TargetGroups.tsx b/app/scripts/modules/amazon/src/loadBalancer/configure/application/TargetGroups.tsx
@@ -47,9 +47,12 @@ export class TargetGroups extends React.Component<ITargetGroupsProps, ITargetGro
   private checkBetween(errors: any, object: any, fieldName: string, min: number, max: number) {
     const field = object[fieldName];
     if (!Number.isNaN(field)) {
-      errors[fieldName] =
+      const error =
         Validators.minValue(min)(field, robotToHuman(fieldName)) ||
         Validators.maxValue(max)(field, robotToHuman(fieldName));
+      if (error) {
+        errors[fieldName] = error;
+      }
     }
   }