Skip to content

Commit

Permalink
refactor(kubernetes): isolate v1 code (#7451)
Browse files Browse the repository at this point in the history
  • Loading branch information
maggieneterval committed Sep 27, 2019
1 parent f535e52 commit e667bdf
Show file tree
Hide file tree
Showing 151 changed files with 81 additions and 85 deletions.
15 changes: 0 additions & 15 deletions app/scripts/modules/kubernetes/src/securityGroup/reader.js

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { ISecurityGroupsByAccount, ISecurityGroup } from '@spinnaker/core';

export class KubernetesSecurityGroupReader {
public static resolveIndexedSecurityGroup(
indexedSecurityGroups: ISecurityGroupsByAccount,
container: ISecurityGroup,
securityGroupId: string,
): ISecurityGroup {
return indexedSecurityGroups[container.account][container.region][securityGroupId];
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import _ from 'lodash';

import { AccountService, ExpectedArtifactService } from '@spinnaker/core';

import { KubernetesProviderSettings } from '../../kubernetes.settings';
import { KubernetesProviderSettings } from '../../../kubernetes.settings';

module.exports = angular
.module('spinnaker.kubernetes.clusterCommandBuilder.service', [])
Expand Down
94 changes: 47 additions & 47 deletions app/scripts/modules/kubernetes/src/v1/kubernetes.v1.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ import { module } from 'angular';

import { CloudProviderRegistry, DeploymentStrategyRegistry } from '@spinnaker/core';

import { KUBERNETES_KEY_VALUE_DETAILS } from '../common/keyValueDetails.component';
import { KUBERNETES_TOLERATIONS } from '../common/tolerations/tolerations.component';
import { KUBERNETES_SECURITY_CONTEXT_SELECTOR } from '../container/securityContext/securityContextSelector.component';
import { KUBERNETES_SERVERGROUP_ARTIFACTEXTRACTOR } from '../serverGroup/artifactExtractor';
import '../help/kubernetes.help';
import { KUBERNETES_KEY_VALUE_DETAILS } from './common/keyValueDetails.component';
import { KUBERNETES_TOLERATIONS } from './common/tolerations/tolerations.component';
import { KUBERNETES_SECURITY_CONTEXT_SELECTOR } from './container/securityContext/securityContextSelector.component';
import { KUBERNETES_SERVERGROUP_ARTIFACTEXTRACTOR } from './serverGroup/artifactExtractor';
import '../shared/help/kubernetes.help';
import { KubernetesProviderSettings } from '../kubernetes.settings';
import { KubernetesSecurityGroupReader } from 'kubernetes/shared/securityGroup/securityGroup.reader';

import '../logo/kubernetes.logo.less';
import '../shared/logo/kubernetes.logo.less';

// load all templates into the $templateCache
const templates = require.context('kubernetes', true, /\.html$/);
Expand All @@ -19,41 +20,40 @@ templates.keys().forEach(function(key) {

export const KUBERNETES_V1_MODULE = 'spinnaker.kubernetes.v1';
module(KUBERNETES_V1_MODULE, [
require('../autoscaler/autoscaler.write.service').name,
require('../cluster/cluster.kubernetes.module').name,
require('../container/configurer.directive').name,
require('../container/probe.directive').name,
require('../event/event.directive').name,
require('../instance/details/details.kubernetes.module').name,
require('./autoscaler/autoscaler.write.service').name,
require('./cluster/cluster.kubernetes.module').name,
require('./container/configurer.directive').name,
require('./container/probe.directive').name,
require('./event/event.directive').name,
require('./instance/details/details.kubernetes.module').name,
KUBERNETES_KEY_VALUE_DETAILS,
KUBERNETES_SECURITY_CONTEXT_SELECTOR,
require('../loadBalancer/configure/configure.kubernetes.module').name,
require('../loadBalancer/details/details.kubernetes.module').name,
require('../loadBalancer/transformer').name,
require('../namespace/multiSelectField.component').name,
require('../namespace/selectField.directive').name,
require('../pipeline/stages/destroyAsg/kubernetesDestroyAsgStage').name,
require('../pipeline/stages/disableAsg/kubernetesDisableAsgStage').name,
require('../pipeline/stages/disableCluster/kubernetesDisableClusterStage').name,
require('../pipeline/stages/enableAsg/kubernetesEnableAsgStage').name,
require('../pipeline/stages/findAmi/kubernetesFindAmiStage').name,
require('../pipeline/stages/resizeAsg/resizeStage').name,
require('../pipeline/stages/runJob/runJobStage').name,
require('../pipeline/stages/scaleDownCluster/scaleDownClusterStage').name,
require('../pipeline/stages/shrinkCluster/shrinkClusterStage').name,
require('../proxy/ui.service').name,
require('../search/resultFormatter').name,
require('../securityGroup/configure/configure.kubernetes.module').name,
require('../securityGroup/details/details.kubernetes.module').name,
require('../securityGroup/reader').name,
require('../securityGroup/transformer').name,
require('../serverGroup/configure/CommandBuilder').name,
require('../serverGroup/configure/configure.kubernetes.module').name,
require('../serverGroup/details/details.kubernetes.module').name,
require('./loadBalancer/configure/configure.kubernetes.module').name,
require('./loadBalancer/details/details.kubernetes.module').name,
require('./loadBalancer/transformer').name,
require('./namespace/multiSelectField.component').name,
require('./namespace/selectField.directive').name,
require('./pipeline/stages/destroyAsg/kubernetesDestroyAsgStage').name,
require('./pipeline/stages/disableAsg/kubernetesDisableAsgStage').name,
require('./pipeline/stages/disableCluster/kubernetesDisableClusterStage').name,
require('./pipeline/stages/enableAsg/kubernetesEnableAsgStage').name,
require('./pipeline/stages/findAmi/kubernetesFindAmiStage').name,
require('./pipeline/stages/resizeAsg/resizeStage').name,
require('./pipeline/stages/runJob/runJobStage').name,
require('./pipeline/stages/scaleDownCluster/scaleDownClusterStage').name,
require('./pipeline/stages/shrinkCluster/shrinkClusterStage').name,
require('./proxy/ui.service').name,
require('./search/resultFormatter').name,
require('./securityGroup/configure/configure.kubernetes.module').name,
require('./securityGroup/details/details.kubernetes.module').name,
require('./securityGroup/transformer').name,
require('./serverGroup/configure/CommandBuilder').name,
require('./serverGroup/configure/configure.kubernetes.module').name,
require('./serverGroup/details/details.kubernetes.module').name,
KUBERNETES_SERVERGROUP_ARTIFACTEXTRACTOR,
require('../serverGroup/paramsMixin').name,
require('../serverGroup/transformer').name,
require('../validation/applicationName.validator').name,
require('./serverGroup/paramsMixin').name,
require('./serverGroup/transformer').name,
require('../shared/validation/applicationName.validator').name,
KUBERNETES_TOLERATIONS,
]).config(() => {
CloudProviderRegistry.registerProvider('kubernetes', {
Expand All @@ -64,38 +64,38 @@ module(KUBERNETES_V1_MODULE, [
resultFormatter: 'kubernetesSearchResultFormatter',
},
logo: {
path: require('../logo/kubernetes.logo.svg'),
path: require('../shared/logo/kubernetes.logo.svg'),
},
image: {
reader: 'kubernetesImageReader',
},
instance: {
detailsTemplateUrl: require('../instance/details/details.html'),
detailsTemplateUrl: require('./instance/details/details.html'),
detailsController: 'kubernetesInstanceDetailsController',
},
loadBalancer: {
transformer: 'kubernetesLoadBalancerTransformer',
detailsTemplateUrl: require('../loadBalancer/details/details.html'),
detailsTemplateUrl: require('./loadBalancer/details/details.html'),
detailsController: 'kubernetesLoadBalancerDetailsController',
createLoadBalancerTemplateUrl: require('../loadBalancer/configure/wizard/createWizard.html'),
createLoadBalancerTemplateUrl: require('./loadBalancer/configure/wizard/createWizard.html'),
createLoadBalancerController: 'kubernetesUpsertLoadBalancerController',
},
securityGroup: {
reader: 'kubernetesSecurityGroupReader',
reader: KubernetesSecurityGroupReader,
transformer: 'kubernetesSecurityGroupTransformer',
detailsTemplateUrl: require('../securityGroup/details/details.html'),
detailsTemplateUrl: require('./securityGroup/details/details.html'),
detailsController: 'kubernetesSecurityGroupDetailsController',
createSecurityGroupTemplateUrl: require('../securityGroup/configure/wizard/createWizard.html'),
createSecurityGroupTemplateUrl: require('./securityGroup/configure/wizard/createWizard.html'),
createSecurityGroupController: 'kubernetesUpsertSecurityGroupController',
},
serverGroup: {
artifactExtractor: 'kubernetesServerGroupArtifactExtractor',
skipUpstreamStageCheck: true,
transformer: 'kubernetesServerGroupTransformer',
detailsTemplateUrl: require('../serverGroup/details/details.html'),
detailsTemplateUrl: require('./serverGroup/details/details.html'),
detailsController: 'kubernetesServerGroupDetailsController',
cloneServerGroupController: 'kubernetesCloneServerGroupController',
cloneServerGroupTemplateUrl: require('../serverGroup/configure/wizard/wizard.html'),
cloneServerGroupTemplateUrl: require('./serverGroup/configure/wizard/wizard.html'),
commandBuilder: 'kubernetesServerGroupCommandBuilder',
configurationService: 'kubernetesServerGroupConfigurationService',
paramsMixin: 'kubernetesServerGroupParamsMixin',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import _ from 'lodash';

import { KubernetesProviderSettings } from '../kubernetes.settings';
import { KubernetesProviderSettings } from '../../kubernetes.settings';

const angular = require('angular');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ const angular = require('angular');

import { AccountService, PipelineConfigService } from '@spinnaker/core';

import { KUBERNETES_LIFECYCLE_HOOK_CONFIGURER } from 'kubernetes/container/lifecycleHook.component';
import { KUBERNETES_CONTAINER_ENVIRONMENT_FROM } from 'kubernetes/container/environmentFrom.component';
import { KUBERNETES_LIFECYCLE_HOOK_CONFIGURER } from 'kubernetes/v1/container/lifecycleHook.component';
import { KUBERNETES_CONTAINER_ENVIRONMENT_FROM } from 'kubernetes/v1/container/environmentFrom.component';

module.exports = angular
.module('spinnaker.kubernetes.pipeline.stage.runJobStage.configure', [
require('kubernetes/container/commands.component').name,
require('kubernetes/container/arguments.component').name,
require('kubernetes/container/environmentVariables.component').name,
require('kubernetes/container/volumes.component').name,
require('kubernetes/container/ports.component').name,
require('kubernetes/container/resources.component').name,
require('kubernetes/container/probe.directive').name,
require('kubernetes/v1/container/commands.component').name,
require('kubernetes/v1/container/arguments.component').name,
require('kubernetes/v1/container/environmentVariables.component').name,
require('kubernetes/v1/container/volumes.component').name,
require('kubernetes/v1/container/ports.component').name,
require('kubernetes/v1/container/resources.component').name,
require('kubernetes/v1/container/probe.directive').name,
KUBERNETES_LIFECYCLE_HOOK_CONFIGURER,
KUBERNETES_CONTAINER_ENVIRONMENT_FROM,
])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ import _ from 'lodash';

import { Registry } from '@spinnaker/core';

import { KUBERNETES_IMAGE_ID_FILTER } from 'kubernetes/presentation/imageId.filter';
import { KUBERNETES_IMAGE_ID_FILTER } from 'kubernetes/v1/presentation/imageId.filter';

const angular = require('angular');

module.exports = angular
.module('spinnaker.kubernetes.pipeline.stage.runJobStage', [
require('kubernetes/container/commands.component').name,
require('kubernetes/container/arguments.component').name,
require('kubernetes/container/environmentVariables.component').name,
require('kubernetes/container/volumes.component').name,
require('kubernetes/image/image.reader').name,
require('kubernetes/v1/container/commands.component').name,
require('kubernetes/v1/container/arguments.component').name,
require('kubernetes/v1/container/environmentVariables.component').name,
require('kubernetes/v1/container/volumes.component').name,
require('kubernetes/v1/image/image.reader').name,
require('./runJobExecutionDetails.controller').name,
require('./configureJob.controller').name,
KUBERNETES_IMAGE_ID_FILTER,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const angular = require('angular');

import { KubernetesProviderSettings } from '../kubernetes.settings';
import { KubernetesProviderSettings } from '../../kubernetes.settings';

module.exports = angular.module('spinnaker.proxy.kubernetes.ui.service', []).factory('kubernetesProxyUiService', [
'$interpolate',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const angular = require('angular');

import { KubernetesProviderSettings } from '../kubernetes.settings';
import { KubernetesProviderSettings } from '../../kubernetes.settings';

module.exports = angular
.module('spinnaker.kubernetes.securityGroup.transformer', [])
Expand Down
8 changes: 4 additions & 4 deletions app/scripts/modules/kubernetes/src/v2/kubernetes.v2.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { module } from 'angular';

import { CloudProviderRegistry, STAGE_ARTIFACT_SELECTOR_COMPONENT_REACT, YAML_EDITOR_COMPONENT } from '@spinnaker/core';

import '../logo/kubernetes.logo.less';
import '../shared/logo/kubernetes.logo.less';

import { KUBERNETES_MANIFEST_DELETE_CTRL } from './manifest/delete/delete.controller';
import { KUBERNETES_MANIFEST_SCALE_CTRL } from './manifest/scale/scale.controller';
Expand Down Expand Up @@ -39,6 +39,7 @@ import { ManifestWizard } from 'kubernetes/v2/manifest/wizard/ManifestWizard';
import { KUBERNETES_ENABLE_MANIFEST_STAGE } from 'kubernetes/v2/pipelines/stages/traffic/enableManifest.stage';
import { KUBERNETES_DISABLE_MANIFEST_STAGE } from 'kubernetes/v2/pipelines/stages/traffic/disableManifest.stage';
import { KUBERNETES_V2_RUN_JOB_STAGE } from 'kubernetes/v2/pipelines/stages/runJob/runJobStage';
import { KubernetesSecurityGroupReader } from 'kubernetes/shared/securityGroup/securityGroup.reader';

// React stages
import './pipelines/stages/deployManifest/deployManifestStage';
Expand Down Expand Up @@ -74,7 +75,6 @@ module(KUBERNETES_V2_MODULE, [
KUBERNETES_MANIFEST_ARTIFACT,
KUBERNETES_V2_LOAD_BALANCER_TRANSFORMER,
KUBERNETES_V2_SECURITY_GROUP_TRANSFORMER,
require('../securityGroup/reader').name,
KUBERNETES_DELETE_MANIFEST_STAGE,
KUBERNETES_SCALE_MANIFEST_STAGE,
KUBERNETES_UNDO_ROLLOUT_MANIFEST_STAGE,
Expand All @@ -98,7 +98,7 @@ module(KUBERNETES_V2_MODULE, [
name: 'Kubernetes',
skin: 'v2',
logo: {
path: require('../logo/kubernetes.icon.svg'),
path: require('../shared/logo/kubernetes.icon.svg'),
},
serverGroup: {
CloneServerGroupModal: ManifestWizard,
Expand All @@ -118,7 +118,7 @@ module(KUBERNETES_V2_MODULE, [
transformer: 'kubernetesV2LoadBalancerTransformer',
},
securityGroup: {
reader: 'kubernetesSecurityGroupReader',
reader: KubernetesSecurityGroupReader,
CreateSecurityGroupModal: ManifestWizard,
detailsController: 'kubernetesV2SecurityGroupDetailsCtrl',
detailsTemplateUrl: require('./securityGroup/details/details.html'),
Expand Down

0 comments on commit e667bdf

Please sign in to comment.