Skip to content

Commit

Permalink
fix(core): Fix pipeline configurer for new cache format (#5163)
Browse files Browse the repository at this point in the history
  • Loading branch information
Justin Reynolds committed Apr 12, 2018
1 parent ecb84af commit f196cf4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import * as _ from 'lodash';

import { ViewStateCache } from 'core/cache';

const angular = require('angular');

import { OVERRIDE_REGISTRY } from 'core/overrideRegistry/override.registry';
Expand Down Expand Up @@ -45,7 +47,6 @@ module.exports = angular
executionService,
executionsTransformer,
pipelineConfigService,
viewStateCache,
overrideRegistry,
$location,
) {
Expand All @@ -71,7 +72,7 @@ module.exports = angular
})
.finally(() => this.setViewState({ loadingHistory: false }));

var configViewStateCache = viewStateCache.get('pipelineConfig');
var configViewStateCache = ViewStateCache.get('pipelineConfig');

function buildCacheKey() {
return pipelineConfigService.buildViewStateCacheKey($scope.application.name, $scope.pipeline.id);
Expand Down
7 changes: 0 additions & 7 deletions app/scripts/modules/core/src/task/tasks.controller.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,10 @@ describe('Controller: tasks', function() {
$q.when(null).then(params.submitMethod);
},
};
var viewStateCache = {
createCache: function() {
return { get: angular.noop, put: angular.noop };
},
get: angular.noop,
};
scope = $rootScope.$new();
controller = $controller('TasksCtrl', {
app: application,
$scope: scope,
viewStateCache: viewStateCache,
confirmationModalService: confirmationModalService,
taskWriter: taskWriter,
});
Expand Down

0 comments on commit f196cf4

Please sign in to comment.