feat(cf): prefix apps manager and metrics urls with https:// (#6637)

Co-Authored-By: Ria Stein <eleftheria.kousathana@gmail.com>
spinnaker · Mar 18, 2019 · f80dfc5 · f80dfc5
1 parent d00b45f
commit f80dfc5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/...ripts/modules/cloudfoundry/src/serverGroup/details/sections/ApplicationManagerSection.tsx b/...ripts/modules/cloudfoundry/src/serverGroup/details/sections/ApplicationManagerSection.tsx
@@ -10,12 +10,16 @@ export class ApplicationManagerSection extends React.Component<ICloudFoundryServ
 
   public render(): JSX.Element {
     const { serverGroup } = this.props;
+    const { appsManagerUri } = serverGroup;
     return (
       <>
-        {serverGroup.appsManagerUri && (
+        {appsManagerUri && (
           <CollapsibleSection heading="Apps Manager" defaultExpanded={true}>
             <div>
-              <a href={serverGroup.appsManagerUri} target="_blank">
+              <a
+                href={appsManagerUri.startsWith('https://') ? appsManagerUri : 'https://' + appsManagerUri}
+                target="_blank"
+              >
                 Apps Manager
               </a>
             </div>

diff --git a/app/scripts/modules/cloudfoundry/src/serverGroup/details/sections/MetricsSection.tsx b/app/scripts/modules/cloudfoundry/src/serverGroup/details/sections/MetricsSection.tsx
@@ -10,12 +10,13 @@ export class MetricsSection extends React.Component<ICloudFoundryServerGroupDeta
 
   public render(): JSX.Element {
     const { serverGroup } = this.props;
+    const { metricsUri } = serverGroup;
     return (
       <>
-        {serverGroup.metricsUri && (
+        {metricsUri && (
           <CollapsibleSection heading="Metrics" defaultExpanded={true}>
             <div>
-              <a href={serverGroup.metricsUri} target="_blank">
+              <a href={metricsUri.startsWith('https://') ? metricsUri : 'https://' + metricsUri} target="_blank">
                 Metrics
               </a>
             </div>