Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gce): render backend services in edit deploy stage #3436

Merged
merged 1 commit into from Mar 28, 2017
Merged

fix(gce): render backend services in edit deploy stage #3436

merged 1 commit into from Mar 28, 2017

Conversation

danielpeach
Copy link
Contributor

Solves the backend service part of this bug: spinnaker/spinnaker#1516

@jtk54 or @duftler please review.

jtk54
jtk54 approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

duftler
duftler approved these changes Mar 28, 2017
View reviewed changes
Copy link

@duftler duftler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danielpeach danielpeach merged commit d84f93f into spinnaker:master Mar 28, 2017
@danielpeach danielpeach deleted the gce-render-backend-services-in-pipeline-edit-deploy-stage branch March 28, 2017 19:56
nzthiago pushed a commit to microsoft/deck that referenced this pull request Apr 17, 2017
@danielpeach @nzthiago
fix(gce): render backend services in edit deploy stage (spinnaker#3436)
62d6cf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtk54 jtk54 jtk54 approved these changes

@duftler duftler duftler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danielpeach @jtk54 @duftler