refactor(core): convert sticky-header to a component #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrsquared
commented
Apr 16, 2017
| @@ -1,6 +1,5 @@ | |||
| <div class="cluster-container" ng-class="{disabled: serverGroup.isDisabled}"> | |||
| <div class="server-group-title" sticky-header added-offset-height="69" | |||
| sticky-if="headerIsSticky()"> | |||
There was a problem hiding this comment.
headerIsSticky() was always undefined, so this was never sticky.
|
LGTM |
meerajose
added a commit
to meerajose/deck
that referenced
this pull request
May 22, 2019
Pulling the latest for issue spinnaker#3537
meerajose
added a commit
to meerajose/deck
that referenced
this pull request
May 22, 2019
meerajose
added a commit
to meerajose/deck
that referenced
this pull request
May 22, 2019
meerajose
added a commit
to meerajose/deck
that referenced
this pull request
May 23, 2019
…spinnaker#3537 spinnaker/spinnaker#3537 Update app/scripts/modules/google/src/help/gce.help.ts Co-Authored-By: Maggie Neterval <mneterval@google.com> fix(google): FR: Help text on GCE load balancer type selection screen spinnaker/spinnaker#3537 Made the changes to show helptext in each of the Load Balancer Type
maggieneterval
pushed a commit
that referenced
this pull request
Jun 7, 2019
) * fix(deck) : FR: Help text on GCE load balancer type selection screen #3537 spinnaker/spinnaker#3537 * Update app/scripts/modules/google/src/help/gce.help.ts Co-Authored-By: Maggie Neterval <mneterval@google.com> * fix(google): FR: Help text on GCE load balancer type selection screen spinnaker/spinnaker#3537 Made the changes to show helptext in each of the Load Balancer Type * fix(google) : FR: Help text on GCE load balancer type selection screen #3537 spinnaker/spinnaker#3537 Update app/scripts/modules/google/src/help/gce.help.ts Co-Authored-By: Maggie Neterval <mneterval@google.com> fix(google): FR: Help text on GCE load balancer type selection screen spinnaker/spinnaker#3537 Made the changes to show helptext in each of the Load Balancer Type * Update app/scripts/modules/google/src/help/gce.help.ts Co-Authored-By: Dave Dorbin <ddorbin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React world doesn't have an analog to attribute directives. Convert sticky-header to a component so we can start to use
sticky-headerin react components.Eventually we will convert this to a React component, but this is a logical first step.
@anotherchrisberry PTAL