fix(core/pageTitle): Use promise based API for showing/hiding spinner #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just return types on functions, but otherwise LGTM. |
|
Will fix unit tests |
christopherthielen
force-pushed
the
SPIN-2569
branch
from
2cf70bf
to
fa74729
Compare
christopherthielen
force-pushed
the
SPIN-2569
branch
from
fa74729
to
eba692d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI-Router 1.0
$stateChange*events polyfill isn't 100% backwards compatible (apparently). Switch toTransitionServicepromise based API and maintain a reference count of pending transitions.