-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes): new deployment representation in cluster view #5617
Conversation
@ethanfrogers @sbwsg @benjaminws @lwander @demobox What do you think? I'll fix it up, add tests, fix tests, etc, etc, if this is an improvement. |
Addresses spinnaker/spinnaker#3160 |
I think it's sexy. 😄 I think there may be some confusion that the parent box is the |
kind of like your mockup in spinnaker/spinnaker#3160 |
👍 |
Agreed that, if we're going to surface kinds, it would be more consistent to do that in multiple places, e.g. also on Server Groups (and perhaps as a toggleable option in the UI?) For now, I think it would be interesting to consider what, if anything, would make sense top-left in the bounding box for the server group manager, next to the icon. Is there any useful name or other identifying information we could put there? |
7f2c638
to
18fdaba
Compare
18fdaba
to
edcb35d
Compare
edcb35d
to
8aeef0d
Compare
Clicking the top of the grouping opens the deployment details on the left side.
When selected, looks like this: