Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): new deployment representation in cluster view #5617

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

danielpeach
Copy link
Contributor

@danielpeach danielpeach commented Aug 15, 2018

new_deployments

Clicking the top of the grouping opens the deployment details on the left side.

When selected, looks like this:
selected_deployment

@danielpeach
Copy link
Contributor Author

danielpeach commented Aug 15, 2018

@ethanfrogers @sbwsg @benjaminws @lwander @demobox What do you think? I'll fix it up, add tests, fix tests, etc, etc, if this is an improvement.

@danielpeach
Copy link
Contributor Author

Addresses spinnaker/spinnaker#3160

@ethanfrogers
Copy link
Contributor

I think it's sexy. 😄 I think there may be some confusion that the parent box is the Deployment. I wonder if there would be any value in including the kind somewhere in each box.

@ethanfrogers
Copy link
Contributor

kind of like your mockup in spinnaker/spinnaker#3160

@ghost
Copy link

ghost commented Aug 15, 2018

👍

@demobox
Copy link

demobox commented Aug 15, 2018

I wonder if there would be any value in including the kind somewhere in each box.

Agreed that, if we're going to surface kinds, it would be more consistent to do that in multiple places, e.g. also on Server Groups (and perhaps as a toggleable option in the UI?)

For now, I think it would be interesting to consider what, if anything, would make sense top-left in the bounding box for the server group manager, next to the icon. Is there any useful name or other identifying information we could put there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants