Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipeline_templates): Display "Force Rebake" checkbox for MPT #5854

Merged
merged 2 commits into from
Oct 29, 2018
Merged

feat(pipeline_templates): Display "Force Rebake" checkbox for MPT #5854

merged 2 commits into from
Oct 29, 2018

Commits on Oct 29, 2018

  1. feat(pipeline_templates): Display "Force Rebake" checkbox for MPT 

    When manually executing templated pipelines, the "Force Rebake" checkbox is missing, even though the pipeline contains a bake stage. Templated pipelines do not contain any stages before runtime, so the bake stage is never asked to inject its custom logic into the manual execution modal.
This is a simple 90/10-solution that just iterates through previous executions, finds the previous execution that actually ran, and naïvely copies the stages to the pipeline, so that the bake stage magic is executed. It might result in false positives and negatives if you are changing the pipeline template, but as the main structure of a pipeline rarely changes and the fact that there are no bad consequences of displaying a force rebake checkbox when there is no bake stage, I think this is good enough.
    @jervi
    jervi committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    93d0694 View commit details
    Browse the repository at this point in the history

  2. Take 2: Planning a new execution instead of using a previous one

    @jervi
    jervi committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    27060e9 View commit details
    Browse the repository at this point in the history