Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove invalid <g> from HoverablePopover #5904

Merged
merged 3 commits into from
Oct 30, 2018
Merged

refactor(core): Remove invalid <g> from HoverablePopover #5904

merged 3 commits into from
Oct 30, 2018

Conversation

jrsquared
Copy link
Contributor

No description provided.

@erikmunson
Copy link
Member

erikmunson commented Oct 26, 2018

hey justin

The tag <g> is unrecognized in this browser.

@jrsquared
Copy link
Contributor Author

I was sick of all the lies.

Copy link
Contributor

@christopherthielen christopherthielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@christopherthielen christopherthielen merged commit 1abc6ba into spinnaker:master Oct 30, 2018
@christopherthielen
Copy link
Contributor

am admin

christopherthielen added a commit to christopherthielen/deck that referenced this pull request Oct 31, 2018
57b1e49  chore(core/presentation): Update formik from 0.11.11 to 1.3.1 (spinnaker#5917)
c0842ad fix(provider/cf): fetch services on a per-region basis
f22fecd feat(core/presentation): Introduce Validation class for reusable validation fns. (spinnaker#5913)
9eacd0c chore(core/pipeline): Cleaning up imports (spinnaker#5914)
b08bab2 refactor(core/projects): Simplify TrashButton click handler
1abc6ba refactor(core): Remove invalid <g> from HoverablePopover (spinnaker#5904)
8523bbd test(core/cluster): fix lint error unused variable (spinnaker#5910)
cc68c9c feat(core): Support a date constraint on trigger parameters (spinnaker#5907)
9488e33 feat(pipeline_templates): Display "Force Rebake" checkbox for MPT (spinnaker#5854)
christopherthielen added a commit that referenced this pull request Oct 31, 2018
57b1e49  chore(core/presentation): Update formik from 0.11.11 to 1.3.1 (#5917)
c0842ad fix(provider/cf): fetch services on a per-region basis
f22fecd feat(core/presentation): Introduce Validation class for reusable validation fns. (#5913)
9eacd0c chore(core/pipeline): Cleaning up imports (#5914)
b08bab2 refactor(core/projects): Simplify TrashButton click handler
1abc6ba refactor(core): Remove invalid <g> from HoverablePopover (#5904)
8523bbd test(core/cluster): fix lint error unused variable (#5910)
cc68c9c feat(core): Support a date constraint on trigger parameters (#5907)
9488e33 feat(pipeline_templates): Display "Force Rebake" checkbox for MPT (#5854)
@jrsquared jrsquared deleted the remove-g branch November 14, 2018 05:15
gcomstock pushed a commit to gcomstock/deck that referenced this pull request Dec 3, 2018
gcomstock pushed a commit to gcomstock/deck that referenced this pull request Dec 3, 2018
57b1e49  chore(core/presentation): Update formik from 0.11.11 to 1.3.1 (spinnaker#5917)
c0842ad fix(provider/cf): fetch services on a per-region basis
f22fecd feat(core/presentation): Introduce Validation class for reusable validation fns. (spinnaker#5913)
9eacd0c chore(core/pipeline): Cleaning up imports (spinnaker#5914)
b08bab2 refactor(core/projects): Simplify TrashButton click handler
1abc6ba refactor(core): Remove invalid <g> from HoverablePopover (spinnaker#5904)
8523bbd test(core/cluster): fix lint error unused variable (spinnaker#5910)
cc68c9c feat(core): Support a date constraint on trigger parameters (spinnaker#5907)
9488e33 feat(pipeline_templates): Display "Force Rebake" checkbox for MPT (spinnaker#5854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants