Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): Add network fixture support for functional tests #6203

Merged
1 commit merged into from Dec 14, 2018
Merged

feat(tests): Add network fixture support for functional tests #6203

1 commit merged into from Dec 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 14, 2018

Add mountebank library to record and replay network fixtures so that
you dont need Gate running to exercise the UI.

Network fixtures can be relatively large. For the two simple tests
written so far the fixtures are several hundred kilobytes. To avoid
ballooning Deck's repo size I plan to place fixtures in a publicly
accessible bucket and only have them downloaded when the test runner
needs them.

Add mountebank library to record and replay network fixtures so that
you dont need Gate running to exercise the UI.

Network fixtures can be relatively large. For the two simple tests
written so far the fixtures are several hundred kilobytes. To avoid
ballooning Deck's repo size I plan to place fixtures in a publicly
accessible bucket and only have them downloaded when the test runner
needs them.
@ghost ghost requested review from lwander and maggieneterval December 14, 2018 14:55
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, excited to use this

@ghost ghost merged commit c92d463 into spinnaker:master Dec 14, 2018
@ghost ghost deleted the add-functional-test-network-fixture-support branch December 14, 2018 15:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants