-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(artifacts): add ivy and maven expected artifact editors #6241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the .svg
files are missing. Otherwise, looks good to me. Would also like @sbwsg to take a look as he wrote a lot of the front-end artifact code so is more knowledgeable about it.
4d1e252
to
185d036
Compare
Yep, got them added. Must have had a gitignore on them somewhere. |
Code lgtm. Where are the logos from & what terms are they released under? |
Both Ivy and Maven are Apache projects, and logos are taken from their project sites. |
#6315) * chore(core): Bump version to 0.0.305 80091f1 fix(core): disable manual executions while trigger data loads (#6301) 308a991 feat(core): use Ace Editor for pipeline/stage JSON editing (#6226) f455307 feat(core): allow setting params via query string on manual execution (#6302) c48bac2 feat(artifacts): Changed helm artifact API requests (#6202) 616e46e fix(core/account): Return empty array if no preferred zones are found in a region e052526 refactor(core/help): Switch HelpField to PureComponent 2c3e5df feat(artifacts): add ivy and maven expected artifact editors (#6241) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) dac9b21 fix(core): fix next CRON trigger calculation offset (#6242) 6b7c1ec fix(core): avoid in sync race condition when saving pipelines (#6235) d29b359 feat(core): show pipeline stage durations by default (#6215) 70be323 feat(stage): manual judgement continue button moved to right (#6292) 641a283 styles(core): Making the main ui-view container positive relative (#6264) 425ca35 feat(core/deploy): Support `scaleDown` as part of a rolling red/black deployment (#6265) * chore(amazon): Bump version to 0.0.148 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) fb6e6c0 fix(aws): clarify all ports/protocols on IP range ingress (#6231) e571c95 fix(aws): provide help explanation when load balancer delete is disabled (#6236) 9a6d8fb feat(aws): make image sort options sticky; sort by TS by default (#6267) 73952e2 fix(amazon/loadBalancer): Restore the "security group removed" warning when switching regions * chore(titus): Bump version to 0.0.65 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280)
In many cases artifact repository UI's surface coordinates as part of text helping you inject them into builds. Splitting the coordinate into 3 independent input text boxes would be annoying to the user: