fix(triggers): Add pipeline name to search request #6703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When searching for a manually started pipeline by eventId, we should also pass in the pipeline name to reduce the amount of data returned from the persistence store.
jtk54
approved these changes
Mar 15, 2019
| ); | ||
| } | ||
|
|
||
| public waitUntilTriggeredPipelineAppears(application: Application, eventId: string): IRetryablePromise<any> { | ||
| public waitUntilTriggeredPipelineAppears( |
There was a problem hiding this comment.
Can we also limit the retry period here to something reasonable?
There was a problem hiding this comment.
Yeah, I'm working on another PR that will either limit the retry period, or move the retry to look in the execution data source already in the front end rather than hitting the back end again.
maggieneterval
approved these changes
Mar 15, 2019
anotherchrisberry
added a commit
that referenced
this pull request
Mar 20, 2019
#6726) * chore(core): Bump version to 0.0.345 29b001b fix({core,cloudfoundry}/deploy): better red/black, rolling red/black help text (#6699) 647e331 perf(core): cache subnets in window session (#6717) 5b6f229 refactor(core): use non-deprecated tasks endpoint for app tasks (#6721) 061a60c fix(triggers): Add timeout to polling on manual trigger (#6707) 40c5e09 fix(concourse): Fix concourse trigger config (#6715) 2ac15b2 fix(artifacts): Fix SpEL text input used in React components (#6712) 8c4104f fix(trigger): Fix react trigger components don't receive prop updates (#6711) a5a54bd feat(kubernetes): add expression evaluation options to bake and deploy manifest stages (#6696) 78786f3 fix(artifacts): Fix trigger artifact feature conditionalization (#6708) 04746e0 fix(artifacts): HTTP artifact needs to set the reference field (#6679) 51eeba4 chore(core): upgrade the version to formik 1.4.1 (#6705) 4f826d1 fix(cf): fix the alignment issue for artifacts in deploy SG (#6701) 2d9fb15 fix(triggers): Add pipeline name to search request (#6703) 75de845 feat(triggers): Add Concourse trigger type (#6692) e2940b4 feat(cf): Share/Unshare services (#6685) 88c8b5d feat(core): save pipelines stage was added (#6654) 4a95a78 fix(artifacts): Make artifacts and artifactsRewrite flags mutually exclusive (#6694) 50cffc9 chore(artifactory): Polish imports and labels (#6693) 4ac54ce feat(core/deploy): UI widget for 'Delay Before Scale Down' (#6698) 792fcaa feat(core): add jenkins artifact type (#6690) 7f68f22 refactor(core): Remove triggerViaEcho feature flag (#6680) * chore(amazon): Bump version to 0.0.181 51eeba4 chore(core): upgrade the version to formik 1.4.1 (#6705) 515bccb feature(aws): Add the cloudformation stage (#6521) * chore(titus): Bump version to 0.0.80 33d674d fix(titus): use arrow function to avoid bad this binding in callback (#6724) 8a6cdfc feat(titus): Surface env and resources for runjob stage (#6697) 51eeba4 chore(core): upgrade the version to formik 1.4.1 (#6705)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for a manually started pipeline by eventId, we should also pass in the pipeline name to reduce the amount of data returned from the persistence store.