New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): reactify CRON trigger #7020

Merged

Jammy-Louie merged 1 commit into spinnaker:master from pivotal:refactor-cron-trig

May 22, 2019

Jammy-Louie commented May 17, 2019

spinnaker/spinnaker#4295

Author

Jammy-Louie commented May 17, 2019

Screen shots of the refactored CRON trigger to React

Author

Jammy-Louie commented May 17, 2019

Hopefully maintained previously existing functionality.

this is the last trigger to be converted to react, after this is merged I can start converting the triggers directive

Jammy-Louie requested a review from christopherthielen

May 17, 2019 14:52

Jammy-Louie added the angular2react label

anotherchrisberry reviewed

View reviewed changes

app/scripts/modules/core/src/pipeline/config/triggers/cron/CronAdvance.tsx Outdated Show resolved Hide resolved

Jammy-Louie force-pushed the refactor-cron-trig branch from 33f2087 to 359b1fd Compare

May 21, 2019 14:10

anotherchrisberry reviewed

View reviewed changes

app/scripts/modules/core/src/pipeline/config/triggers/cron/CronTrigger.tsx Outdated Show resolved Hide resolved

anotherchrisberry reviewed

View reviewed changes

app/scripts/modules/core/src/pipeline/config/triggers/cron/CronAdvance.tsx Outdated Show resolved Hide resolved

anotherchrisberry reviewed

View reviewed changes

app/scripts/modules/core/src/pipeline/config/triggers/cron/CronAdvance.tsx Outdated Show resolved Hide resolved

anotherchrisberry reviewed

View reviewed changes

app/scripts/modules/core/src/pipeline/config/triggers/cron/CronHourly.tsx Show resolved Hide resolved

anotherchrisberry reviewed

View reviewed changes

app/scripts/modules/core/src/pipeline/config/triggers/cron/CronHourly.tsx Show resolved Hide resolved

Jammy-Louie force-pushed the refactor-cron-trig branch 2 times, most recently from 56f5bfe to 1ac519d Compare

May 21, 2019 20:01


          refactor(core): reactify CRON trigger

287d011

Jammy-Louie force-pushed the refactor-cron-trig branch from 1ac519d to 287d011 Compare

May 21, 2019 20:08

Jammy-Louie merged commit 2466379 into spinnaker:master

spinnakerbot added the target-release/1.15 label

Jammy-Louie deleted the refactor-cron-trig branch

May 22, 2019 15:49

anotherchrisberry mentioned this pull request

chore(core): Bump version to 0.0.372 #7049

Merged

anotherchrisberry added a commit that referenced this pull request


          chore(core): Bump version to 0.0.372 (#7049)

d794173

a683832 fix(core): set runAsUser field correctly on triggers (#7048)
f0287a1 fix(runJob/kubernetes): use explicit pod name (#7039)
fc1cd1b fix(core): allow clearing of run as user field in triggers (#7045)
2466379 refactor(core): reactify CRON trigger (#7020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment