fix(docker): Stop losing manually defined imageId #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anotherchrisberry
approved these changes
May 21, 2019
anotherchrisberry
added a commit
that referenced
this pull request
May 21, 2019
…91 (#7041) * chore(core): Bump version to 0.0.371 2268217 feat(core): allow any json subtypes in API response (#7040) b55e3b8 fix(core/amazon): validate target group healthcheck fields (#6962) c9791e6 fix(core): blur active element when rendering task monitor (#7034) 43fb8a0 fix(core): unwrap font-awesome span from button label (#7032) 8982b34 fix(cf): server group header build links should precede images (#7027) 59b69b8 fix(executions): Fixed missing account tags in standalone (#7036) f3fd44c fix(artifact/helm): fix version list (#7030) f1ca123 fix(chaos): Stack and detail are actually not required (#7028) b505b5c refactor(core): minor fixes to the refactored triggers (#7024) 9cf9a62 fix(authz): Handle apps without execute permissions (#7017) 6390c71 fix(kubernetes): Fix NPE in bake manifest details (#7022) * chore(docker): Bump version to 0.0.40 bd7c5b6 fix(docker): Stop losing manually defined imageId (#7037) * chore(amazon): Bump version to 0.0.191 b55e3b8 fix(core/amazon): validate target group healthcheck fields (#6962) a2a3bbb feat(amazon): remove s3 as store type option for baking (#7035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were losing manually defined imageId on refreshes because didn't properly handle the
defineManuallycase.Basically we only call
synchronizeChangeswith the parts (org, repo, tag/digest), but when we're defining the imageId manually, we end up generating anundefinedimageId because tag was undefined.tl;dr
For the defineManually case, we just needed to parse imageId into
IDockerImagePartsbefore passing it intosynchronizeChanges