refactor(core): reactify pipelineRoles component #7104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refactored pipeline roles to React:
Much smaller change then my last PR |
maggieneterval
approved these changes
Jun 11, 2019
Jammy-Louie
force-pushed
the
reactify-allowedRoles
branch
from
706007f
to
b24d035
Compare
| export const PipelineRoles = (props: IPipelineRolesConfigProps) => { | ||
| const [allowedRoles, setAllowedRoles] = useState([]); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I don't think you need a useEffect at all... since getAuthenticatedUser() is synchronous you can either:
- simply grab the value each time
- cache it using
useMemo
const allowedRoles = useMemo(() => AuthenticationService.getAuthenticatedUser().roles, []);
anotherchrisberry
added a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.