feat(core/amazon): add a visual indicator to infra managed by Keel #7161
Conversation
|
The following commits need their title changed: Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
| </ul> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
was this on purpose?
There was a problem hiding this comment.
oh yeah, forgot I did this otherwise would've commented it. all this markup is all hidden and seemingly has been forever — we don't actually let you mutate target groups directly from the details pane. Effectively the only noticeable change is that this silly whitespace goes away:
app/scripts/modules/core/src/managed/managedResourceDetailsIndicator.component.ts
Outdated
Show resolved
Hide resolved
| <p> | ||
| <b>Spinnaker is continuously managing this resource.</b> | ||
| </p> | ||
| <p>Changes made in the UI will be stomped in favor of the existing declarative configuration.</p> |
There was a problem hiding this comment.
Is there anything we can link to here? Unless you already know about keel and declarative delivery, it's not really clear what any of this means.
There was a problem hiding this comment.
Indeed, a 'what on earth is this referring to?' doc on spinnaker.io for this tooltip is on the list to write in the near-term. For now anything keel-related is restricted to a few test apps as we work out documentation and some other rough edges.
Co-Authored-By: Chris Berry <chrisb@netflix.com>
…98 and titus to 0.0.100 (#7163) * chore(core): Bump version to 0.0.380 2fd1aa9 feat(core/amazon): add a visual indicator to infra managed by Keel (#7161) * chore(docker): Bump version to 0.0.43 e08e36f feat(docker): allow extra inline help on tag selector (#7143) * chore(amazon): Bump version to 0.0.198 2fd1aa9 feat(core/amazon): add a visual indicator to infra managed by Keel (#7161) * chore(titus): Bump version to 0.0.100 422be22 fix(titus): allow security group in cluster config by name (#7160) cdd6f23 chore(package): Just Update Prettier™
The first PR for bringing keel into the UI — this is a quick (largely experimental) attempt at indicating resources are managed. Currently applies to clusters, load balancers/target groups, and security groups.
Right now this is implemented via entity tags, but may change in the future. I'm not particularly tied to any of the specifics (including new directory structures, etc.).