refactor(titus/serverGroup): Reactify Titus Resize Server Group Modal #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| </div> | ||
|
|
||
| {!!errorMessage && ( |
There was a problem hiding this comment.
Uses formik, but only shows one error message and always shows that error message in the same spot.
| } | ||
|
|
||
| function SimpleMode({ formik, serverGroup, toggleMode }: IAdvancedModeProps) { | ||
| useEffect(() => { |
There was a problem hiding this comment.
I love how simple and clean useEffect can be.
| ); | ||
|
|
||
| @Overridable('titus.serverGroup.CapacityDetailsSection') | ||
| export class TitusCapacityDetailsSection extends React.Component<ICapacityDetailsSectionProps> { |
There was a problem hiding this comment.
this is still a class component because @Overridable needs a class component
|
The following commits need their title changed: Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 3, 2019
6630f9b refactor(core/serverGroup): Extract capacity details components to reuse across providers (spinnaker#7182) 20df06e refactor(titus/serverGroup): Reactify Titus Resize Server Group Modal (spinnaker#7175)
christopherthielen
added a commit
that referenced
this pull request
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also reactify the server group capacity details section.
Also give this the Changes treatment we did in Amazon provider
use formik and hooks