Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix link to strategic merge patch docs #7177

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

brianstorti
Copy link
Contributor

@brianstorti brianstorti commented Jul 2, 2019

The file was moved in this PR kubernetes/community#3145

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • d9f7bed: Fix link to strategic merge patch docs

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

Copy link
Contributor

@louisjimenez louisjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating. one comment and looks like commit title needs reformatting.

app/scripts/modules/kubernetes/src/help/kubernetes.help.ts Outdated Show resolved Hide resolved
@brianstorti brianstorti changed the title Fix link to strategic merge patch docs fix(core): Fix link to strategic merge patch docs Jul 2, 2019
@louisjimenez louisjimenez merged commit f6163a9 into spinnaker:master Jul 2, 2019
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jul 3, 2019
f6163a9 fix(kubernetes): Fix link to strategic merge patch docs (spinnaker#7177)
aca6626 feat(k8s): Enable new artifacts workflow in Patch Manifest (spinnaker#7109)
cdd6f23 chore(package): Just Update Prettier™
5d63230 fix(kubernetes): use cncf approved svg (spinnaker#7130)
fc95ae4 fix(kubernetes): fix req. artifacts to bind selector in patch manifest stage (spinnaker#7095)
christopherthielen added a commit that referenced this pull request Jul 3, 2019
f6163a9 fix(kubernetes): Fix link to strategic merge patch docs (#7177)
aca6626 feat(k8s): Enable new artifacts workflow in Patch Manifest (#7109)
cdd6f23 chore(package): Just Update Prettier™
5d63230 fix(kubernetes): use cncf approved svg (#7130)
fc95ae4 fix(kubernetes): fix req. artifacts to bind selector in patch manifest stage (#7095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants