Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add license finder plugin #7188

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

Jammy-Louie
Copy link

No description provided.

@christopherthielen
Copy link
Contributor

can you provide some context on this?

@Jammy-Louie
Copy link
Author

sure thing @christopherthielen, we need to have the repos scanned by our legal team here and I tried to have this repo scanned but it failed to scan because our legal team's scripts would try to inject the following if not present

plugins {
  id "com.github.hierynomous.license version "0.15.0"
}

some of the existing plugins are not compatible with this style of plugins block. If I apply the license finder plugin their script would no longer fail.

@christopherthielen
Copy link
Contributor

I have no problem with this. However, if this license checker is gradle based, I doubt it's scanning the right things. Also note I'd like to get rid of as much gradle usage as possible (not now, but in the future "when I have time")

@Jammy-Louie
Copy link
Author

Thats fine, I think the legal team's script just spots the build.gradle file and tries to run a scan through gradle in addition to their other scans. If the gradle usage eventually goes away that would be great and it would stop trying to run the scan with gradle

@Jammy-Louie Jammy-Louie merged commit 20137e4 into spinnaker:master Jul 17, 2019
@Jammy-Louie Jammy-Louie deleted the license-finder branch July 17, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants