fix(amazon): Update default internalPort for CLBs to 80 #7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Jul 13, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 15, 2019
b2c0cf0 fix(amazon): Update default internalPort for CLBs to 80 (spinnaker#7220)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea why we defaulted to 0 for the internal port, but this seems to fail silently somewhere in the backend, basically with a task completion that ends up with no listener created (probably because 0 isn't really a port).
80 seems more reasonable since we already default to HTTP anyways. This way if someone forgot to actually configure their desired internal port, at least they'll get a listener created to the wrong port instead of wondering why the listener didn't get created