fix(core/pipeline): exclude correlation IDs (and more) when re-running #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Sep 6, 2019
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Sep 12, 2019
e0ce768 feat(pager): Looking up multiple apps by name to page (spinnaker#7387) 42c2946 fix(core): ensure filter tag removal removes tags from filter (spinnaker#7212) 733132b refactor(core): reactify the show pipeline history modal (spinnaker#7382) 7d65ea9 refactor(titus): Adding load balancer incompatibility (spinnaker#7386) 3e76186 fix(core/pipeline): exclude correlation IDs (and more) when re-running (spinnaker#7374)
alanmquach
added a commit
that referenced
this pull request
Sep 12, 2019
e0ce768 feat(pager): Looking up multiple apps by name to page (#7387) 42c2946 fix(core): ensure filter tag removal removes tags from filter (#7212) 733132b refactor(core): reactify the show pipeline history modal (#7382) 7d65ea9 refactor(titus): Adding load balancer incompatibility (#7386) 3e76186 fix(core/pipeline): exclude correlation IDs (and more) when re-running (#7374)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
e0ce768 feat(pager): Looking up multiple apps by name to page (spinnaker#7387) 42c2946 fix(core): ensure filter tag removal removes tags from filter (spinnaker#7212) 733132b refactor(core): reactify the show pipeline history modal (spinnaker#7382) 7d65ea9 refactor(titus): Adding load balancer incompatibility (spinnaker#7386) 3e76186 fix(core/pipeline): exclude correlation IDs (and more) when re-running (spinnaker#7374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added the ability to re-run active executions (#7293). Turns out there are some junk fields in execution triggers that have historically been fine to accidentally include when manually triggering (e.g.
executionId,eventId), but when an execution is running there's acorrelationIdfield that will thwart any attempts to trigger another pipeline. This just strips out those junk fields when a re-run modal is mounted, which seems to do the trick.