configure apache to log to stdout/stderr #7375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
paulczar
commented
Sep 4, 2019
| @@ -44,6 +44,10 @@ mv spinnaker.conf /etc/apache2/sites-available | |||
|
|
|||
| a2ensite spinnaker | |||
|
|
|||
| # Disable default site | |||
|
|
|||
| a2dissite 000-default | |||
There was a problem hiding this comment.
we're not using the default, so its good hygiene to disable it.
paulczar
commented
Sep 4, 2019
| @@ -1,5 +1,7 @@ | |||
| apt-get update | |||
| apt-get install apache2 -y | |||
| rm -rf /var/lib/apt/lists/* | |||
There was a problem hiding this comment.
there's a bit of space to save by cleaning up the apt cache.
Reports of deck failing with a full /var led me to finding that apache is not configured as per docker best practices to log to stdout/stderr. This addresses that. Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
paulczar
force-pushed
the
apache-to-stdout
branch
from
31e5a5d
to
652bd40
Compare
|
@Jammy-Louie : I'm not sure I'm the best person to look at this PR...is there someone more familiar with deck you could ask? |
scottfrederick
approved these changes
Sep 6, 2019
Jammy-Louie
approved these changes
Sep 6, 2019
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
Reports of deck failing with a full /var led me to finding that apache is not configured as per docker best practices to log to stdout/stderr. This addresses that. Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache is configured by default to log to
/var/log...which fills up real quick with logs from kubernetes health checks and regular traffic, eventually the pod runs out of space. This modifies the config to log to stdout/stderr instead inline with docker/kubernetes best practices and should help protect the filesystem of the containers/pods.Signed-off-by: Paul Czarkowski username.taken@gmail.com