Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(amazon): choices prop is actually optional #7379

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

alanmquach
Copy link
Contributor

Since it has default props

Copy link
Member

@erikmunson erikmunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great PR

@alanmquach alanmquach merged commit c93f7e8 into spinnaker:master Sep 5, 2019
@alanmquach alanmquach deleted the choices-optional branch September 5, 2019 20:19
alanmquach added a commit to alanmquach/deck that referenced this pull request Sep 5, 2019
c93f7e8 refactor(amazon): choices prop is actually optional (spinnaker#7379)
alanmquach added a commit that referenced this pull request Sep 5, 2019
c93f7e8 refactor(amazon): choices prop is actually optional (#7379)
alanmquach added a commit to alanmquach/deck that referenced this pull request Sep 12, 2019
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
c93f7e8 refactor(amazon): choices prop is actually optional (spinnaker#7379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants