Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nexus): nexus trigger selectable in UI #7381

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

claymccoy
Copy link
Contributor

No description provided.

Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm assuming there are backend components that need to be merged before we merge this?

Copy link

@Jammy-Louie Jammy-Louie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claymccoy claymccoy merged commit 23540b6 into spinnaker:master Sep 13, 2019
@claymccoy
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.16

@spinnakerbot
Copy link
Contributor

Cherry pick successful: #7398

plumpy added a commit that referenced this pull request Sep 13, 2019
plumpy added a commit that referenced this pull request Sep 13, 2019
…1.16-23540b61003d8eb08c73ee9e53d6ff15e69c5ecd

Revert "fix(nexus): nexus trigger selectable in UI (#7381)"
alanmquach added a commit to alanmquach/deck that referenced this pull request Sep 16, 2019
b396658 fix(core): fix manual execution (spinnaker#7408)
476ad62 feat(pipeline): Custom alert for start manual execution dialog (spinnaker#7406)
ec1d32f fix(help): reflect reality in rollingredblack help text bubble-things (spinnaker#7405)
23540b6 fix(nexus): nexus trigger selectable in UI (spinnaker#7381)
alanmquach added a commit that referenced this pull request Sep 16, 2019
b396658 fix(core): fix manual execution (#7408)
476ad62 feat(pipeline): Custom alert for start manual execution dialog (#7406)
ec1d32f fix(help): reflect reality in rollingredblack help text bubble-things (#7405)
23540b6 fix(nexus): nexus trigger selectable in UI (#7381)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
b396658 fix(core): fix manual execution (spinnaker#7408)
476ad62 feat(pipeline): Custom alert for start manual execution dialog (spinnaker#7406)
ec1d32f fix(help): reflect reality in rollingredblack help text bubble-things (spinnaker#7405)
23540b6 fix(nexus): nexus trigger selectable in UI (spinnaker#7381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants