fix(amazon): Fix compatibility when cloudProviders missing #7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Sep 16, 2019
2821438 fix(amazon): Fix compatibility when cloudProviders missing (spinnaker#7410)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
2821438 fix(amazon): Fix compatibility when cloudProviders missing (spinnaker#7410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored this method a couple times and accidentally ended up with the wrong boolean.
As the comment states, when cloudProviders is missing (as in an empty array), we want to assume it is compatible. This means
isIncompatibleWithAllProvidersshould befalse. Accidentally left it astruefrom when this method was "is compatible" instead of "is incompatible".