-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(artifacts): Support custom artifacts with custom type #7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some recent changes to the Expected Artifacts feature has severely broken backwards compatibility with artifacts that have a custom type (for instance Igor can create artifacts with type `deb` or `rpm`). This commit will make Deck be more lenient when it encounters legacy artifacts that does not strictly adhere to the new standard. It will also add back the UI fields `type`, `name`, `version` and `location` for custom artifacts.
Jammy-Louie
reviewed
Sep 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jammy-Louie
approved these changes
Sep 20, 2019
erikmunson
pushed a commit
to erikmunson/deck
that referenced
this pull request
Sep 23, 2019
5d2e469 feat(core/pipeline): Add timestamp for failed executions (spinnaker#7419) 3cfb3f1 feat(core/pipeline): Make custom artifacts more readable (spinnaker#7418) 0034fa8 fix(core/pipeline): Add space before Source-link for failed executions (spinnaker#7420) bce3ac5 fix(core/pipeline): standardize manual execution field layouts (spinnaker#7413) 9c0a994 fix(artifacts): Support custom artifacts with custom type (spinnaker#7415)
erikmunson
pushed a commit
that referenced
this pull request
Sep 23, 2019
* chore(core): Bump version to 0.0.411 5d2e469 feat(core/pipeline): Add timestamp for failed executions (#7419) 3cfb3f1 feat(core/pipeline): Make custom artifacts more readable (#7418) 0034fa8 fix(core/pipeline): Add space before Source-link for failed executions (#7420) bce3ac5 fix(core/pipeline): standardize manual execution field layouts (#7413) 9c0a994 fix(artifacts): Support custom artifacts with custom type (#7415) * chore(titus): Bump version to 0.0.112 97c85d9 chore(titus): Deprecating pipeline migration strategy (#7414)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
* chore(core): Bump version to 0.0.411 5d2e469 feat(core/pipeline): Add timestamp for failed executions (spinnaker#7419) 3cfb3f1 feat(core/pipeline): Make custom artifacts more readable (spinnaker#7418) 0034fa8 fix(core/pipeline): Add space before Source-link for failed executions (spinnaker#7420) bce3ac5 fix(core/pipeline): standardize manual execution field layouts (spinnaker#7413) 9c0a994 fix(artifacts): Support custom artifacts with custom type (spinnaker#7415) * chore(titus): Bump version to 0.0.112 97c85d9 chore(titus): Deprecating pipeline migration strategy (spinnaker#7414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent changes to the Expected Artifacts feature has severely broken backwards compatibility with artifacts that have a custom type (for instance Igor can create artifacts with type
deb
orrpm
). This commit will make Deck be more lenient when it encounters legacy artifacts that does not strictly adhere to the new standard. It will also add back the UI fieldstype
,name
,version
andlocation
for custom artifacts.