feat(monitored deploy): add basic monitored deploy UI #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchello2000
force-pushed
the
mark/add_monitored_deploy_views
branch
from
4cb12fa
to
8d1b77c
Compare
|
@erikmunson Would love some help from you on this... |
marchello2000
force-pushed
the
mark/add_monitored_deploy_views
branch
from
5c4ec06
to
199b3c0
Compare
christopherthielen
approved these changes
Sep 30, 2019
| import { HelpField } from 'core/help/HelpField'; | ||
| import { NgReact } from 'core/reactShims'; | ||
| import { IServerGroupCommand } from 'core/serverGroup'; | ||
| import Select, { Option } from 'react-select'; |
There was a problem hiding this comment.
we typically put imports from libraries way up at the top ☝️
| </dl> | ||
| {deploymentMonitors && ( | ||
| <div> | ||
| <strong>NOTE:</strong> This information is provided by the{' '} |
There was a problem hiding this comment.
is the {' '} necessary here with the <i> tag following?
There was a problem hiding this comment.
i was trying to put a space, and it was giving me a hard time, i removed it and replaced with
|
|
||
| return ( | ||
| <div className="form-group"> | ||
| {this.state.deploymentMonitors && ( |
There was a problem hiding this comment.
do you want to learn the newer and totally better way to do forms that is definitely the final way we will ever do forms?
There was a problem hiding this comment.
yes... someday... :)?
* Add stage execution details for `notifyDeploymentStarted` and `evaluateDeploymentHealth` stages * Add monitored deploy to selectable strategies
marchello2000
force-pushed
the
mark/add_monitored_deploy_views
branch
from
199b3c0
to
fc13ee4
Compare
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 1, 2019
b55a49a feat(monitored deploy): add basic monitored deploy UI (spinnaker#7426) 5e25501 fix(artifacts/bitbucket): Allow updates to bitbucket default artifact text input Allows updates to the artifact text input even when the regex pattern does not match the bitbucket cloud regex Create regex pattern for bitbucket server to match input against Fixes spinnaker/spinnaker#4958
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 1, 2019
b55a49a feat(monitored deploy): add basic monitored deploy UI (spinnaker#7426) cfe9731 feat(aws): Add copy-to-clipboard button to copy instance id (spinnaker#7388)
christopherthielen
added a commit
that referenced
this pull request
Oct 1, 2019
b55a49a feat(monitored deploy): add basic monitored deploy UI (#7426) 5e25501 fix(artifacts/bitbucket): Allow updates to bitbucket default artifact text input Allows updates to the artifact text input even when the regex pattern does not match the bitbucket cloud regex Create regex pattern for bitbucket server to match input against Fixes spinnaker/spinnaker#4958
christopherthielen
added a commit
that referenced
this pull request
Oct 1, 2019
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Oct 2, 2019
* Add stage execution details for `notifyDeploymentStarted` and `evaluateDeploymentHealth` stages * Add monitored deploy to selectable strategies
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Oct 2, 2019
b55a49a feat(monitored deploy): add basic monitored deploy UI (spinnaker#7426) 5e25501 fix(artifacts/bitbucket): Allow updates to bitbucket default artifact text input Allows updates to the artifact text input even when the regex pattern does not match the bitbucket cloud regex Create regex pattern for bitbucket server to match input against Fixes spinnaker/spinnaker#4958
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Oct 2, 2019
b55a49a feat(monitored deploy): add basic monitored deploy UI (spinnaker#7426) cfe9731 feat(aws): Add copy-to-clipboard button to copy instance id (spinnaker#7388)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
* Add stage execution details for `notifyDeploymentStarted` and `evaluateDeploymentHealth` stages * Add monitored deploy to selectable strategies
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
b55a49a feat(monitored deploy): add basic monitored deploy UI (spinnaker#7426) 5e25501 fix(artifacts/bitbucket): Allow updates to bitbucket default artifact text input Allows updates to the artifact text input even when the regex pattern does not match the bitbucket cloud regex Create regex pattern for bitbucket server to match input against Fixes spinnaker/spinnaker#4958
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
b55a49a feat(monitored deploy): add basic monitored deploy UI (spinnaker#7426) cfe9731 feat(aws): Add copy-to-clipboard button to copy instance id (spinnaker#7388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notifyDeploymentStartedandevaluateDeploymentHealthstagesExecution details view
Strategy configuration view