fix(core/pipeline): Fixes UX of saving non-templated pipelines #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a fix for saving Templated pipelines was applied which removed the assigment of the updated pipeline to 'renderablePipeline'. this fix re-applies the assignment of the 'renderablepipeline' variable but only if the pipeline is non-templated.
christopherthielen
requested review from
louisjimenez,
Jammy-Louie and
erikmunson
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Sep 25, 2019
2b7b60c fix(core/pipeline): Fixes UX of saving non-templated pipelines (spinnaker#7437) 6ccc8cd feat(core/forms): Remove all async support from the spinnaker validation apis (spinnaker#7435) bfa0d17 fix(pipeline): Fix NPE in stage requisiteStageRefIds (spinnaker#7417) a125b03 fix(core/pipeline): Fix execution details chevron for grouped stages (spinnaker#7421)
christopherthielen
added a commit
that referenced
this pull request
Sep 25, 2019
2b7b60c fix(core/pipeline): Fixes UX of saving non-templated pipelines (#7437) 6ccc8cd feat(core/forms): Remove all async support from the spinnaker validation apis (#7435) bfa0d17 fix(pipeline): Fix NPE in stage requisiteStageRefIds (#7417) a125b03 fix(core/pipeline): Fix execution details chevron for grouped stages (#7421)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…aker#7437) Previously, a fix for saving Templated pipelines was applied which removed the assigment of the updated pipeline to 'renderablePipeline'. this fix re-applies the assignment of the 'renderablepipeline' variable but only if the pipeline is non-templated.
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
2b7b60c fix(core/pipeline): Fixes UX of saving non-templated pipelines (spinnaker#7437) 6ccc8cd feat(core/forms): Remove all async support from the spinnaker validation apis (spinnaker#7435) bfa0d17 fix(pipeline): Fix NPE in stage requisiteStageRefIds (spinnaker#7417) a125b03 fix(core/pipeline): Fix execution details chevron for grouped stages (spinnaker#7421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a fix for saving Templated pipelines was applied which removed the assigment of the updated pipeline to 'renderablePipeline'. This fix re-applies the assignment of the 'renderablepipeline' variable but only if the pipeline is non-templated.