Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/pipeline): Revision history is vertically challenged in Safari #7449

Merged
merged 1 commit into from Sep 27, 2019
Merged

fix(core/pipeline): Revision history is vertically challenged in Safari #7449

merged 1 commit into from Sep 27, 2019

Conversation

jervi
Copy link
Contributor

@jervi jervi commented Sep 27, 2019

Safari renders the viewport of the revision history with a height of 34px, which leaves a lot of whitespace unused, and also makes it hard to review the revision history as only two lines can be displayed at once.

image

The padding-left override also makes the revision history stop cropping the pluses and minuses (in all browsers).

image

@jervi
fix(core/pipeline): Revision history is vertically challenged in Safari
931ce42 
Safari renders the viewport of the revision history with a height of 34px, which leaves a lot of whitespace unused, and also makes it hard to review the revision history as only two lines can be displayed at once.

The `padding-left` override also makes the revision history stop cropping the pluses and minuses (in all browsers).
louisjimenez
louisjimenez approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@louisjimenez louisjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@louisjimenez louisjimenez merged commit 4f24db3 into spinnaker:master Sep 27, 2019
@louisjimenez
Copy link
Contributor

@spinnakerbot cherry-pick 1.16

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit 4f24db3) with exit code 1:

error: could not apply 4f24db3ab... fix(core/pipeline): Revision history is vertically challenged in Safari (#7449)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

2 similar comments
@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit 4f24db3) with exit code 1:

error: could not apply 4f24db3ab... fix(core/pipeline): Revision history is vertically challenged in Safari (#7449)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit 4f24db3) with exit code 1:

error: could not apply 4f24db3ab... fix(core/pipeline): Revision history is vertically challenged in Safari (#7449)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

@louisjimenez
Copy link
Contributor

Cherry picked failed because this is adding CSS to a class that didn't exist until after 1.1.6 was cut. Instead this can go in with the rest of the changes for 1.17.x

@jervi jervi deleted the version_modal_height_safari branch September 30, 2019 06:51
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Sep 30, 2019
@christopherthielen
chore(core): Bump version to 0.0.414
eb79726 
57d28c9 fix(core/task): properly cleanup TaskMonitor polling, fix digest thrashing (spinnaker#7458)
564af88 feat(displayName): Adding display name property for the bakery baseOS options (spinnaker#7464)
e0c57af fix(bakeManifest): fix bake manifest UI rendering (spinnaker#7463)
f41d955 fix(core/infrastructure): Fix deep links with filters (spinnaker#7459)
01bc0da fix(help text): update webhook help text (spinnaker#7456)
53300b1 refactor(core/validation): move FormValidator classes to separate files (spinnaker#7460)
1873094 feat(core/utils): Add `traverseObject` which deeply walks object properties (spinnaker#7452)
f535e52 refactor(pipeline): reactify pipeline config actions dropdown (spinnaker#7447)
677ab6b fix(bake/kustomize): fix name validation (spinnaker#7450)
4f24db3 fix(core/pipeline): Revision history is vertically challenged in Safari (spinnaker#7449)
592e74f feat(core/utils): Add 'api' to window.spinnaker object for interactive debugging (spinnaker#7439)
585ac15 fix(pipeline): unset `locked` instead of `lock` when unlocking pipeline (spinnaker#7445)
67fc87e fix(core/pipeline): "Depends On" doesn't always update when reverting (spinnaker#7441)
bd4ba0e fix(core/pipeline): Fix revert button for non-templated pipelines (spinnaker#7440)
45f3c24 feat(core/presentation): Migrate form validation API to class-based API
447d76f fix(core/presentation): In min/max validators, validate that the value is a number
@christopherthielen christopherthielen mentioned this pull request Sep 30, 2019
Merged
christopherthielen added a commit that referenced this pull request Sep 30, 2019
@christopherthielen
chore(core): Bump version to 0.0.414
3377ee1 
57d28c9 fix(core/task): properly cleanup TaskMonitor polling, fix digest thrashing (#7458)
564af88 feat(displayName): Adding display name property for the bakery baseOS options (#7464)
e0c57af fix(bakeManifest): fix bake manifest UI rendering (#7463)
f41d955 fix(core/infrastructure): Fix deep links with filters (#7459)
01bc0da fix(help text): update webhook help text (#7456)
53300b1 refactor(core/validation): move FormValidator classes to separate files (#7460)
1873094 feat(core/utils): Add `traverseObject` which deeply walks object properties (#7452)
f535e52 refactor(pipeline): reactify pipeline config actions dropdown (#7447)
677ab6b fix(bake/kustomize): fix name validation (#7450)
4f24db3 fix(core/pipeline): Revision history is vertically challenged in Safari (#7449)
592e74f feat(core/utils): Add 'api' to window.spinnaker object for interactive debugging (#7439)
585ac15 fix(pipeline): unset `locked` instead of `lock` when unlocking pipeline (#7445)
67fc87e fix(core/pipeline): "Depends On" doesn't always update when reverting (#7441)
bd4ba0e fix(core/pipeline): Fix revert button for non-templated pipelines (#7440)
45f3c24 feat(core/presentation): Migrate form validation API to class-based API
447d76f fix(core/presentation): In min/max validators, validate that the value is a number
Jammy-Louie pushed a commit to pivotal/deck that referenced this pull request Oct 2, 2019
@christopherthielen
chore(core): Bump version to 0.0.414
e0fc62f 
57d28c9 fix(core/task): properly cleanup TaskMonitor polling, fix digest thrashing (spinnaker#7458)
564af88 feat(displayName): Adding display name property for the bakery baseOS options (spinnaker#7464)
e0c57af fix(bakeManifest): fix bake manifest UI rendering (spinnaker#7463)
f41d955 fix(core/infrastructure): Fix deep links with filters (spinnaker#7459)
01bc0da fix(help text): update webhook help text (spinnaker#7456)
53300b1 refactor(core/validation): move FormValidator classes to separate files (spinnaker#7460)
1873094 feat(core/utils): Add `traverseObject` which deeply walks object properties (spinnaker#7452)
f535e52 refactor(pipeline): reactify pipeline config actions dropdown (spinnaker#7447)
677ab6b fix(bake/kustomize): fix name validation (spinnaker#7450)
4f24db3 fix(core/pipeline): Revision history is vertically challenged in Safari (spinnaker#7449)
592e74f feat(core/utils): Add 'api' to window.spinnaker object for interactive debugging (spinnaker#7439)
585ac15 fix(pipeline): unset `locked` instead of `lock` when unlocking pipeline (spinnaker#7445)
67fc87e fix(core/pipeline): "Depends On" doesn't always update when reverting (spinnaker#7441)
bd4ba0e fix(core/pipeline): Fix revert button for non-templated pipelines (spinnaker#7440)
45f3c24 feat(core/presentation): Migrate form validation API to class-based API
447d76f fix(core/presentation): In min/max validators, validate that the value is a number
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@jervi @yunzhangit
fix(core/pipeline): Revision history is vertically challenged in Safa…
289574d 
…ri (spinnaker#7449)

Safari renders the viewport of the revision history with a height of 34px, which leaves a lot of whitespace unused, and also makes it hard to review the revision history as only two lines can be displayed at once.

The `padding-left` override also makes the revision history stop cropping the pluses and minuses (in all browsers).
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@christopherthielen @yunzhangit
chore(core): Bump version to 0.0.414
0797004 
57d28c9 fix(core/task): properly cleanup TaskMonitor polling, fix digest thrashing (spinnaker#7458)
564af88 feat(displayName): Adding display name property for the bakery baseOS options (spinnaker#7464)
e0c57af fix(bakeManifest): fix bake manifest UI rendering (spinnaker#7463)
f41d955 fix(core/infrastructure): Fix deep links with filters (spinnaker#7459)
01bc0da fix(help text): update webhook help text (spinnaker#7456)
53300b1 refactor(core/validation): move FormValidator classes to separate files (spinnaker#7460)
1873094 feat(core/utils): Add `traverseObject` which deeply walks object properties (spinnaker#7452)
f535e52 refactor(pipeline): reactify pipeline config actions dropdown (spinnaker#7447)
677ab6b fix(bake/kustomize): fix name validation (spinnaker#7450)
4f24db3 fix(core/pipeline): Revision history is vertically challenged in Safari (spinnaker#7449)
592e74f feat(core/utils): Add 'api' to window.spinnaker object for interactive debugging (spinnaker#7439)
585ac15 fix(pipeline): unset `locked` instead of `lock` when unlocking pipeline (spinnaker#7445)
67fc87e fix(core/pipeline): "Depends On" doesn't always update when reverting (spinnaker#7441)
bd4ba0e fix(core/pipeline): Fix revert button for non-templated pipelines (spinnaker#7440)
45f3c24 feat(core/presentation): Migrate form validation API to class-based API
447d76f fix(core/presentation): In min/max validators, validate that the value is a number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisjimenez louisjimenez louisjimenez approved these changes

Assignees
No one assigned
Labels
target-release/1.17
Projects
None yet
Milestone
No milestone
3 participants
@jervi @louisjimenez @spinnakerbot