feat(provider/aws): Add roleARN to the deploy cloudformation stage #7492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spinnaker/reviewers The clouddriver PR spinnaker/clouddriver#4080 has been merged. Could you have a quick look at this one? |
|
I don't think the @spinnaker/reviewers works. @christopherthielen if you have time, could you have a look? (sorry for pinging you directly, not sure who is the best person for this repo) |
|
Thank you! |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 11, 2019
74e829d feat(provider/aws): Add roleARN to the deploy cloudformation stage (spinnaker#7492)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
74e829d feat(provider/aws): Add roleARN to the deploy cloudformation stage (spinnaker#7492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify the roleARN permission in the 'deploy cloudformation' stage.
see spinnaker/spinnaker#5004 and spinnaker/clouddriver#4080