Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Show icon when target group registration in progress #7502

Merged

Conversation

caseyhebebrand
Copy link
Contributor

There is no icon next to the target group when it's registration is in progress (JIRA).

Before:
Screen Shot 2019-10-08 at 2 16 25 PM

After:
Screen Shot 2019-10-08 at 1 52 12 PM

Copy link
Contributor

@christopherthielen christopherthielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christopherthielen christopherthielen merged commit 438d22c into spinnaker:master Oct 8, 2019
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Oct 8, 2019
438d22c fix(ui): Add icon when target group registration in progress (spinnaker#7502)
babbe88 refactor(application): reactify delete application section (spinnaker#7501)
christopherthielen added a commit that referenced this pull request Oct 8, 2019
438d22c fix(ui): Add icon when target group registration in progress (#7502)
babbe88 refactor(application): reactify delete application section (#7501)
@caseyhebebrand caseyhebebrand deleted the target-group-progress-icon branch November 20, 2019 19:03
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
438d22c fix(ui): Add icon when target group registration in progress (spinnaker#7502)
babbe88 refactor(application): reactify delete application section (spinnaker#7501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants