fix(core/presentation): fix null reference in ReactSelectInput #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 11, 2019
c18f307 fix(core/presentation): fix null reference in ReactSelectInput (spinnaker#7515) 075bce1 feat(core/presentation): allow markdown in ValidationMessage aef69cf fix(core/presentation): Make all DOMPurify'd links open in a new window (spinnaker#7511) a082909 fix(bakeManifest/helm): rawOverrides option (spinnaker#7514) 752b1ab fix(deck): Show fail fast status code only if they are not pre-configured (spinnaker#7512) d03ce48 fix(core/pipeline): fix Artifactory and Nexus trigger NPE These were throwing upon initial mount because 'error' wasn't defined. a9469e9 refactor: Migrate user code to new validation message API 4c5f532 refactor(core/presentation): Remove validationStatus from forms apis eafb077 refactor(core/presentation): Split forms interfaces into three files: - /forms/fields/interface.ts - /forms/inputs/interface.ts - /forms/layouts/interface.ts 2d6c9e7 feat(core/utils): extract firstDefined utility function b553465 refactor(core/validation): Move ValidationMessage from core/validation to core/presentation/forms/validation 8518286 feat(core/presentation): Extract useValidationData hook aad69b0 fix(core/presentation): Handle empty message in validation message functions, e.g., `errorMessage(undefined)` 8529faf fix(core): fix jumping cursor in trigger inputs (spinnaker#7486) 36192ab fix(core/pipeline): Pass Trigger validateFn to the trigger's Formik
christopherthielen
added a commit
that referenced
this pull request
Oct 11, 2019
c18f307 fix(core/presentation): fix null reference in ReactSelectInput (#7515) 075bce1 feat(core/presentation): allow markdown in ValidationMessage aef69cf fix(core/presentation): Make all DOMPurify'd links open in a new window (#7511) a082909 fix(bakeManifest/helm): rawOverrides option (#7514) 752b1ab fix(deck): Show fail fast status code only if they are not pre-configured (#7512) d03ce48 fix(core/pipeline): fix Artifactory and Nexus trigger NPE These were throwing upon initial mount because 'error' wasn't defined. a9469e9 refactor: Migrate user code to new validation message API 4c5f532 refactor(core/presentation): Remove validationStatus from forms apis eafb077 refactor(core/presentation): Split forms interfaces into three files: - /forms/fields/interface.ts - /forms/inputs/interface.ts - /forms/layouts/interface.ts 2d6c9e7 feat(core/utils): extract firstDefined utility function b553465 refactor(core/validation): Move ValidationMessage from core/validation to core/presentation/forms/validation 8518286 feat(core/presentation): Extract useValidationData hook aad69b0 fix(core/presentation): Handle empty message in validation message functions, e.g., `errorMessage(undefined)` 8529faf fix(core): fix jumping cursor in trigger inputs (#7486) 36192ab fix(core/pipeline): Pass Trigger validateFn to the trigger's Formik
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
c18f307 fix(core/presentation): fix null reference in ReactSelectInput (spinnaker#7515) 075bce1 feat(core/presentation): allow markdown in ValidationMessage aef69cf fix(core/presentation): Make all DOMPurify'd links open in a new window (spinnaker#7511) a082909 fix(bakeManifest/helm): rawOverrides option (spinnaker#7514) 752b1ab fix(deck): Show fail fast status code only if they are not pre-configured (spinnaker#7512) d03ce48 fix(core/pipeline): fix Artifactory and Nexus trigger NPE These were throwing upon initial mount because 'error' wasn't defined. a9469e9 refactor: Migrate user code to new validation message API 4c5f532 refactor(core/presentation): Remove validationStatus from forms apis eafb077 refactor(core/presentation): Split forms interfaces into three files: - /forms/fields/interface.ts - /forms/inputs/interface.ts - /forms/layouts/interface.ts 2d6c9e7 feat(core/utils): extract firstDefined utility function b553465 refactor(core/validation): Move ValidationMessage from core/validation to core/presentation/forms/validation 8518286 feat(core/presentation): Extract useValidationData hook aad69b0 fix(core/presentation): Handle empty message in validation message functions, e.g., `errorMessage(undefined)` 8529faf fix(core): fix jumping cursor in trigger inputs (spinnaker#7486) 36192ab fix(core/pipeline): Pass Trigger validateFn to the trigger's Formik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.